Issue 5133 in pharo: Editor >> cursorEnd: and cursorHome: does not work properly

Status: New
Owner: ----

New issue 5133 by [hidden email]: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

moveCursor: directionBlock forward: forward specialBlock: specialBlock  
event: aKeyboardEvent
        "Private - Move cursor.
        directionBlock is a one argument Block that computes the new Position from  
a given one.
        specialBlock is a one argumentBlock that computes the new position from a  
given one under the alternate semantics.
        Note that directionBlock always is evaluated first."
        | shift indices newPosition |
        shift := aKeyboardEvent shiftPressed.
        indices := self setIndices: shift forward: forward.
        newPosition := directionBlock value: (indices at: #moving).
       
(aKeyboardEvent commandKeyPressed or: [ aKeyboardEvent controlKeyPressed ])
                ifTrue: [newPosition := specialBlock value: newPosition].

        shift
                ifTrue: [self selectMark: (indices at: #fixed) point: newPosition - 1]
                ifFalse: [self selectAt: newPosition]

If you are pressing command or control when moving the cursor, it executes  
a SpecialBlock which is always a dummy block that takes you to the end of  
the text instead of the end of the line.

Removing


(aKeyboardEvent commandKeyPressed or: [ aKeyboardEvent controlKeyPressed ])
                ifTrue: [newPosition := specialBlock value: newPosition].

Makes it work well


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5133 by [hidden email]: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

A proposed fix

Attachments:
        Issue 5133: Editor >> cursorEnd: and cursorHome: does not work  
properly.1.cs  848 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 5133 by [hidden email]: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

Thanks debora. On which image are you working? 1.4? 1.3?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #3 on issue 5133 by [hidden email]: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5133 by [hidden email]: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

That code is in 1.4(at least, so it should be in previous versions), and we  
found it while playing with keymapping hehe


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5133 by [hidden email]: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

ouch Sorry I didn't see this!!! :(
I found it in 1.3
As Guille said, it's on 1.4 too.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed
        Labels: Milestone-1.4

Comment #6 on issue 5133 by [hidden email]: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

in 14286


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5133 by marianopeck: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

Hola deby :)
So...this issue broke something and it is the fact that cmd+shift+arrrow or  
ctrl+shift+arrow does not select words anymore. For example, if I have in a  
workspace this text:

Deby capa

And the cursor is in the first "D" of Deby, if I press ctrl+shift+arrow  
or  cmd+shift+arrrow   the text selection should select "Deby". However, it  
doesn onlt selct the first character...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5133 by [hidden email]: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

Hmmm, yes, I do think too we have to rollback this...  It's brings issues  
in unix too...

Btw, the original issue arised when we removed the not-working task  
switching with cmd+arrow in mac.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #9 on issue 5133 by [hidden email]: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

Ok guille I can rollback it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #10 on issue 5133 by [hidden email]: Editor >> cursorEnd:  
and cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

Rollbacked in 14291


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 5133 by marianopeck: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

should we create another issue for the original problem ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5133 by [hidden email]: Editor >> cursorEnd:  
and cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

Yes I prefer like that there is less to read and we are to the point.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #13 on issue 5133 by marianopeck: Editor >> cursorEnd: and  
cursorHome: does not work properly
http://code.google.com/p/pharo/issues/detail?id=5133

I didn't understand the original issue, so I am not able to open another  
issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker