Issue 5147 in pharo: TestCase>>assert:equals: does not honor contract of #comparingStringBetween:and:

Status: New
Owner: ----
Labels: Milestone-1.3 Type-Bug

New issue 5147 by [hidden email]: TestCase>>assert:equals: does not honor  
contract of #comparingStringBetween:and:
http://code.google.com/p/pharo/issues/detail?id=5147

Currently expected and actual parameters are swapped which results in  
misleading assertion failures.



Attachments:
        TestCase-assertequals.st  301 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Accepted
        Cc: marianopeck

Comment #1 on issue 5147 by [hidden email]: TestCase>>assert:equals: does  
not honor contract of #comparingStringBetween:and:
http://code.google.com/p/pharo/issues/detail?id=5147

Looking at the method versions in my 1.4 image, it seems a mess...
I thought the consensus after issue 4129 was to switch expected and actual  
parameter order, as was done in 5/1/2011 version, but for some reason this  
was reverted?
And then later switched to instead of modifying the parameter order report  
the wrong values as expected and actual?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5147 by [hidden email]: TestCase>>assert:equals: does  
not honor contract of #comparingStringBetween:and:
http://code.google.com/p/pharo/issues/detail?id=5147

IOW the current version is consistent with what was decided, but usage of  
actual and expected in assert:equals: should be swapped.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.3 Milestone-1.4

Comment #3 on issue 5147 by [hidden email]: TestCase>>assert:equals:  
does not honor contract of #comparingStringBetween:and:
http://code.google.com/p/pharo/issues/detail?id=5147

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5147 by [hidden email]: TestCase>>assert:equals:  
does not honor contract of #comparingStringBetween:and:
http://code.google.com/p/pharo/issues/detail?id=5147

what do you mean by usage of actual and expected should be swapped.

I should say that I never understood this problem of assert....


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5147 by [hidden email]: TestCase>>assert:equals: does  
not honor contract of #comparingStringBetween:and:
http://code.google.com/p/pharo/issues/detail?id=5147

The signature in TestCase is:

comparingStringBetween: expected and: actual

but #assert:equals: calls it as

self comparingStringBetween: actual and: expected

This leads to confusion, is annoying, and trivial to fix.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 5147 by [hidden email]: TestCase>>assert:equals:  
does not honor contract of #comparingStringBetween:and:
http://code.google.com/p/pharo/issues/detail?id=5147

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 5147 by [hidden email]: TestCase>>assert:equals:  
does not honor contract of #comparingStringBetween:and:
http://code.google.com/p/pharo/issues/detail?id=5147

in 14417


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5147 by [hidden email]: TestCase>>assert:equals:  
does not honor contract of #comparingStringBetween:and:
http://code.google.com/p/pharo/issues/detail?id=5147

in 14417


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker