Status: Accepted
Owner: ---- Labels: Milestone-1.3 Type-Bug New issue 5153 by [hidden email]: warningAllowed does not work with undefined selectors http://code.google.com/p/pharo/issues/detail?id=5153 Pharo1.3 Latest update: #13299 To reproduce it do: 1) Evaluate: Parser doNotWarnUser. 2) Create a method that sends an undefined message. For example, on Object m1 self qqqq 3) When saving the method, a prompt asking to confirm, correct or cancel that should not be shown becuase doNotWarnUser was setted. To solve it: The method Parser>>correctSelector: proposedKeyword wordIntervals: spots exprInterval: expInt ifAbort: abortAction should be: correctSelector: proposedKeyword wordIntervals: spots exprInterval: expInt ifAbort: abortAction "Correct the proposedKeyword to some selector symbol, correcting the original text if such action is indicated. abortAction is invoked if the proposedKeyword couldn't be converted into a valid selector. Spots is an ordered collection of intervals within the test stream of the for each of the keyword parts." | correctSelector userSelection | "If I don't want to be warned about this, just return - Hernan Wilkinson" self warns ifFalse: [ ^ proposedKeyword asSymbol ]. .... THE REST OF THE METHOD .... This change is implemented in TDDFacilities, package TDD-Facilities-HernanWilkinson.22 (it is on squeaksource) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixReviewNeeded Comment #1 on issue 5153 by [hidden email]: warningAllowed does not work with undefined selectors http://code.google.com/p/pharo/issues/detail?id=5153 I added a small fix for this Attachments: SLICE-Issue-5153-warningAllowed-does-not-work-with-undefined-selectors-EstebanLorenzano.1.mcz 32.9 KB _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Labels: Milestone-1.4 Comment #2 on issue 5153 by [hidden email]: warningAllowed does not work with undefined selectors http://code.google.com/p/pharo/issues/detail?id=5153 to be checked in 1.4, too _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Workneeded Comment #3 on issue 5153 by [hidden email]: warningAllowed does not work with undefined selectors http://code.google.com/p/pharo/issues/detail?id=5153 I can not merge the slice... (Instead of attaching the mcz it should be committed to the inbox with all the packages it depends on) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #4 on issue 5153 by [hidden email]: warningAllowed does not work with undefined selectors http://code.google.com/p/pharo/issues/detail?id=5153 I can not merge the slice... (Instead of attaching the mcz it should be committed to the inbox with all the packages it depends on) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixToInclude Comment #5 on issue 5153 by [hidden email]: warningAllowed does not work with undefined selectors http://code.google.com/p/pharo/issues/detail?id=5153 Ah... merges in 1.3. I attach the chained method for 1.4 Attachments: Parser-correctSelectorwordIntervalsexprIntervalifAbort.st 1.3 KB _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Labels: -Milestone-1.4 Comment #6 on issue 5153 by [hidden email]: warningAllowed does not work with undefined selectors http://code.google.com/p/pharo/issues/detail?id=5153 in 14379 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Integrated Comment #7 on issue 5153 by [hidden email]: warningAllowed does not work with undefined selectors http://code.google.com/p/pharo/issues/detail?id=5153 in 13326 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Free forum by Nabble | Edit this page |