Issue 5156 in pharo: ClassBuilder allows the creation of invalid instance-, class instance-, class-, and pool-variables

Status: Accepted
Owner: renggli
Labels: Milestone-1.3 Milestone-1.4 Type-Bug Importance-High

New issue 5156 by renggli: ClassBuilder allows the creation of invalid  
instance-, class instance-, class-, and pool-variables
http://code.google.com/p/pharo/issues/detail?id=5156

THe class builder does not verify any longer, if instance variables are  
correctly formed. From the definition template and using #addInstVarNamed:  
and friends it is possible to define invalid variables like '0' or '0and1'.  
Clearly such variables cannot be used from Smalltalk code.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5156 by [hidden email]: ClassBuilder allows the  
creation of invalid instance-, class instance-, class-, and pool-variables
http://code.google.com/p/pharo/issues/detail?id=5156

The ClassBuilder did in 2009

...
        instVars := Scanner new scanFieldNames: instVarString.
...

what in some silent mode formatted the field names:

0asd -> asd

Now, since a year we have:

...
instVars := instVarString subStrings: ' '.
...


It happens in 1.2.1 too :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 5156 by [hidden email]: ClassBuilder allows the  
creation of invalid instance-, class instance-, class-, and pool-variables
http://code.google.com/p/pharo/issues/detail?id=5156

added validations using String>>isLegalInstVarName extension from compiler

Attachments:
        Issue 5156: ClassBuilder allows the creation of invalid instance-, class  
instance-, class-, and pool-variables.2.cs  4.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5156 by [hidden email]: ClassBuilder allows the  
creation of invalid instance-, class instance-, class-, and pool-variables
http://code.google.com/p/pharo/issues/detail?id=5156

New CS removing non-sense returns after exceptions :)

Attachments:
        Issue 5156: ClassBuilder allows the creation of invalid instance-, class  
instance-, class-, and pool-variables.3.cs  4.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.3

Comment #4 on issue 5156 by [hidden email]: ClassBuilder allows the  
creation of invalid instance-, class instance-, class-, and pool-variables
http://code.google.com/p/pharo/issues/detail?id=5156

I would not add that to 1.3, it was like that since years and nobody got  
impacted. Just adding it to 1.4.
This way people get less side effects if they update from a major to a  
minor version.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #5 on issue 5156 by [hidden email]: ClassBuilder allows the  
creation of invalid instance-, class instance-, class-, and pool-variables
http://code.google.com/p/pharo/issues/detail?id=5156

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 5156 by [hidden email]: ClassBuilder allows the  
creation of invalid instance-, class instance-, class-, and pool-variables
http://code.google.com/p/pharo/issues/detail?id=5156

in 14365


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker