Issue 5160 in pharo: sourceCodeAt: vs. sourceMethodAt:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5160 in pharo: sourceCodeAt: vs. sourceMethodAt:

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup

New issue 5160 by [hidden email]: sourceCodeAt: vs. sourceMethodAt:
http://code.google.com/p/pharo/issues/detail?id=5160

Class>>sourceCodeAt: vs. Class>>sourceMethodAt: is confusing. They both do  
the same thing, except one returns text and the other returns a string  
(which is not at all obvious from the names). Do we need both? One could  
always derive the string version from the text version sending #asString,  
no?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5160 in pharo: sourceCodeAt: vs. sourceMethodAt:

pharo

Comment #1 on issue 5160 by [hidden email]: sourceCodeAt: vs.  
sourceMethodAt:
http://code.google.com/p/pharo/issues/detail?id=5160

Indeed. Did you check the senders? Because we can deprecate one.
I would prefer to deal with String than Text for core messages.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5160 in pharo: sourceCodeAt: vs. sourceMethodAt:

pharo
Updates:
        Status: FixReviewNeeded
        Labels: Milestone-1.4

Comment #2 on issue 5160 by [hidden email]: sourceCodeAt: vs.  
sourceMethodAt:
http://code.google.com/p/pharo/issues/detail?id=5160

fix attached.



Attachments:
        CleanSourceMethodAt.1.cs  27.7 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5160 in pharo: sourceCodeAt: vs. sourceMethodAt:

pharo
Updates:
        Status: Integrated

Comment #3 on issue 5160 by [hidden email]: sourceCodeAt: vs.  
sourceMethodAt:
http://code.google.com/p/pharo/issues/detail?id=5160

in 14366


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker