Issue 5164 in pharo: use new #isCompact rather than indexIfCompact > 0

Status: Accepted
Owner: marianopeck
Labels: Milestone-1.4

New issue 5164 by marianopeck: use new #isCompact rather than  
indexIfCompact > 0
http://code.google.com/p/pharo/issues/detail?id=5164

Now that we added

Behavior >> isCompact

        ^self indexIfCompact ~= 0


we should change all senders which use #indexIfCompact as #isCompact.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5164 by [hidden email]: use new #isCompact  
rather than indexIfCompact > 0
http://code.google.com/p/pharo/issues/detail?id=5164

YEYEYEYEYEYEYEYEYSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

I hate indexIfCompact because it does not look Smalltalk.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5164 by [hidden email]: use new #isCompact  
rather than indexIfCompact > 0
http://code.google.com/p/pharo/issues/detail?id=5164

BTW isCompact not in 14282


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5164 by marianopeck: use new #isCompact rather than  
indexIfCompact > 0
http://code.google.com/p/pharo/issues/detail?id=5164

no...it was going to be part of the fix of #pointsTo:
but probably I will commit a slice for this first (both, the creation of  
#isCompact and fixing the senders).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5164 by [hidden email]: use new #isCompact  
rather than indexIfCompact > 0
http://code.google.com/p/pharo/issues/detail?id=5164

Mariano I would commit strongly and the other versions with nice comments  
in the code because understanding the implementation is important so that  
we do not clean stupidly. I love when the system teaches me something and  
that I feel clever after.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Cc: [hidden email]

Comment #5 on issue 5164 by marianopeck: use new #isCompact rather than  
indexIfCompact > 0
http://code.google.com/p/pharo/issues/detail?id=5164

Stef, fix in inbox:

Name:  
SLICE-Issue-5164-use-new-isCompact-rather-than-indexIfCompact--0-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 9 January 2012, 10:35:57 pm
UUID: 7f408bc0-1c5a-4489-82ec-d4a3406b28bd
Ancestors:
Dependencies: Kernel-MarianoMartinezPeck.994,  
KernelTests-MarianoMartinezPeck.380

Fix to issue 5164


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #6 on issue 5164 by [hidden email]: use new #isCompact  
rather than indexIfCompact > 0
http://code.google.com/p/pharo/issues/detail?id=5164

in 14286


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker