Issue 5170 in pharo: DNU Inspector>>arrowKey:from:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5170 in pharo: DNU Inspector>>arrowKey:from:

pharo
Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4 Type-Bug

New issue 5170 by [hidden email]: DNU Inspector>>arrowKey:from:
http://code.google.com/p/pharo/issues/detail?id=5170

If you press cmd + something that has not bee taken in account :)

inspectorKey: aChar from: view
        "Respond to a Command key issued while the cursor is over my field list"

        aChar == $i ifTrue: [^ self selection inspect].
        aChar == $I ifTrue: [^ self selection explore].
        aChar == $b ifTrue: [^ self browseMethodFull].
        aChar == $h ifTrue: [^ self classHierarchy].
        aChar == $c ifTrue: [^ self copyName].
        aChar == $p ifTrue: [^ self browseFullProtocol].
        aChar == $N ifTrue: [^ self browseClassRefs].

        ^ self arrowKey: aChar from: view


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5170 in pharo: DNU Inspector>>arrowKey:from:

pharo
Updates:
        Status: FixReviewNeeded

Comment #2 on issue 5170 by [hidden email]: DNU  
Inspector>>arrowKey:from:
http://code.google.com/p/pharo/issues/detail?id=5170

Little fix

Attachments:
        Issue 5170: DNU Inspector>>arrowKey:from:.1.cs  626 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5170 in pharo: DNU Inspector>>arrowKey:from:

pharo
Updates:
        Cc: marianopeck

Comment #3 on issue 5170 by [hidden email]: DNU  
Inspector>>arrowKey:from:
http://code.google.com/p/pharo/issues/detail?id=5170

Mariano does it break the selection (I never use it)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5170 in pharo: DNU Inspector>>arrowKey:from:

pharo

Comment #4 on issue 5170 by [hidden email]: DNU  
Inspector>>arrowKey:from:
http://code.google.com/p/pharo/issues/detail?id=5170

This DNU is caused because Inspector used to be a subclass of StringHolder  
which is subclass of Model, which implements:

arrowKey: aChar from: view
        "backstop; all the PluggableList* classes actually handle arrow keys, and  
the models handle other keys."
        ^false

But now Inspector inherits from Object and thus, the DNU :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5170 in pharo: DNU Inspector>>arrowKey:from:

pharo
Updates:
        Status: FixToInclude

Comment #5 on issue 5170 by [hidden email]: DNU  
Inspector>>arrowKey:from:
http://code.google.com/p/pharo/issues/detail?id=5170

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5170 in pharo: DNU Inspector>>arrowKey:from:

pharo
Updates:
        Status: Integrated

Comment #6 on issue 5170 by [hidden email]: DNU  
Inspector>>arrowKey:from:
http://code.google.com/p/pharo/issues/detail?id=5170

in 14322


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker