Issue 5171 in pharo: Remove styling from PreDebug warning message

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.3 Milestone-1.4 Type-Bug

New issue 5171 by [hidden email]: Remove styling from PreDebug  
warning message
http://code.google.com/p/pharo/issues/detail?id=5171

PreDebug warning messages mess with styling.

To reproduce:

true and: 1 and: 2.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5171 by [hidden email]: Remove styling from  
PreDebug warning message
http://code.google.com/p/pharo/issues/detail?id=5171

Proposed fix (adding a NullTextStyler before adding the edit to the  
PluggableTextMorph).

Attachments:
        Issue 5171: Remove styling from PreDebug warning message.1.cs  1.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5171 by [hidden email]: Remove styling from  
PreDebug warning message
http://code.google.com/p/pharo/issues/detail?id=5171

already fixed a time ago in 1.4, see MorphicUIManager>>buildNotifyTextPane:  
versions.
it is preferable to just send #styled: false to the text morph.
IHMO, NullTextStyler should not be instantiated here.

for 1.4, in inbox:
SLICE-Issue-5171-Remove-styling-from-PreDebug-warning-message

for 1.3, the attached cs

Attachments:
        Remove styling from PreDebug warning message.2.cs  1.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #3 on issue 5171 by [hidden email]: Remove styling from  
PreDebug warning message
http://code.google.com/p/pharo/issues/detail?id=5171

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.3

Comment #4 on issue 5171 by [hidden email]: Remove styling from  
PreDebug warning message
http://code.google.com/p/pharo/issues/detail?id=5171

in 14284. Thanks


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #5 on issue 5171 by [hidden email]: Remove styling from  
PreDebug warning message
http://code.google.com/p/pharo/issues/detail?id=5171

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker