Comment #5 on issue 5180 by
[hidden email]:
ConnectionQueue>>getConnectionOrNil not working
http://code.google.com/p/pharo/issues/detail?id=5180I can't read CZ ;-)
I just see that you are opening a priviledged port, 80 ! Please try with
something like 8080. The following:
| queue connection |
queue := ConnectionQueue
portNumber: 8080
queueLength: 50.
[
[
connection := queue getConnectionOrNil.
connection
ifNotNil: [ Transcript crShow: 'Got connection'. connection
sendCommand: 'OK'; close ].
(Delay forMilliseconds: 250) wait. Processor yield
] repeat
] fork.
Works for me, in 1.3 using the Pharo VM on Mac OS X, when I connect with
telnet from a terminal.
You have to change #listenLoop to
| newConnection |
socket := Socket newTCP.
"We'll accept four simultanous connections at the same time"
socket listenOn: portNumber backlogSize: 4.
"If the listener is not valid then the we cannot use the
BSD style accept() mechanism."
socket isValid ifFalse: [^self oldStyleListenLoop].
[true] whileTrue: [
socket isValid ifFalse: [
"socket has stopped listening for some reason"
socket destroy.
(Delay forMilliseconds: 10) wait.
^self listenLoop ].
[newConnection := socket waitForAcceptFor: 10]
on: ConnectionTimedOut
do: [:ex | newConnection := nil].
(newConnection notNil and: [newConnection isConnected])
ifTrue: [(accessSema critical: [connections size < maxQueueLength])
ifFalse: [newConnection close. newConnection := nil]]
ifFalse: [newConnection := nil].
(newConnection notNil and: [newConnection isConnected]) ifTrue: [
accessSema critical: [connections addLast: newConnection].
newConnection := nil.
self changed].
self pruneStaleConnections].
Apart from the #waitForAcceptFor modification, there was an additional
problem in the code trying to limit the number of connections (according to
the comment, a modification by gvc).
Be careful, if you are debugging this, the server socket remains open in
lot's of cases (this isn't very robust code). Call #destroy on the
ConnectionQueue, or terminate the relevant process(es) by hand, and do
3 timesRepeat: [ Smalltalk garbageCollect ]
So that open sockets are close by the finalization code. See if all is well
by doing
Socket allInstances
HTH,
Sven
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Locked
