Issue 5188 in pharo: Fast Drag doesn't work anymore

Status: Accepted
Owner: [hidden email]

New issue 5188 by [hidden email]: Fast Drag doesn't work anymore
http://code.google.com/p/pharo/issues/detail?id=5188

In the image #14284 fast drag doesn't work anymore.
The mouse moves of the window after a few pixels offset.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5188 by [hidden email]: Fast Drag doesn't work  
anymore
http://code.google.com/p/pharo/issues/detail?id=5188

Strange I wonder what we changed. Do you know the latest one where it  
worked?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5188 by marianopeck: Fast Drag doesn't work anymore
http://code.google.com/p/pharo/issues/detail?id=5188

Grrr I have been bitten by this one as well.
To try it:
UITheme currentSettings fastDragging: true.

It doesn't work in 14282  but it works in 14239

I don't have images in the middle :(


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email] [hidden email] [hidden email]

Comment #3 on issue 5188 by marianopeck: Fast Drag doesn't work anymore
http://code.google.com/p/pharo/issues/detail?id=5188

I cc'ed the only guys I know that may help


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5188 by [hidden email]: Fast Drag doesn't work  
anymore
http://code.google.com/p/pharo/issues/detail?id=5188

Is there a way to load new versions only one by one ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #5 on issue 5188 by [hidden email]: Fast Drag doesn't work  
anymore
http://code.google.com/p/pharo/issues/detail?id=5188

It comes from here:

SystemWindow>>#doFastFrameDrag: grabPoint
        "Do fast frame dragging from the given point"

        | offset newBounds outerWorldBounds |
        outerWorldBounds := self boundsIn: nil.
        offset := outerWorldBounds origin - grabPoint.
        newBounds := outerWorldBounds newRectButtonPressedDo: [:f |

"USED TO BE Sensor cursorPoint + offset extent: outerWorldBounds extent]."

                self activeHand cursorPoint + offset extent: outerWorldBounds extent].
        Display deferUpdatesIn: Display boundingBox while: [
                self position: (self globalPointToLocal: newBounds topLeft)]

Sorry Igor ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5188 by [hidden email]: Fast Drag doesn't work  
anymore
http://code.google.com/p/pharo/issues/detail?id=5188

And for the resize, this one:

SystemWindow>>#doFastWindowReframe: ptName

        | newBounds |
        "For fast display, only higlight the rectangle during loop"
        newBounds := self bounds newRectButtonPressedDo: [:f |
                f
                        withSideOrCorner: ptName
                        setToPoint: (self pointFromWorld: self activeHand cursorPoint)
                        setToPoint: (self pointFromWorld: Sensor cursorPoint)
                        minExtent: self minimumExtent].
        Display deferUpdatesIn: Display boundingBox while: [
                self bounds: newBounds].

        ^newBounds.


Actually, I have no clue how to fix that :s


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #7 on issue 5188 by [hidden email]: Fast Drag doesn't work  
anymore
http://code.google.com/p/pharo/issues/detail?id=5188

I propose this as a fix. But maybe I have done things wrongly.

Ask for a review ^^

\me magically invoke Igor ^^

Attachments:
        FixFastDrag.1.cs  1.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5188 by marianopeck: Fast Drag doesn't work anymore
http://code.google.com/p/pharo/issues/detail?id=5188

Thanks Ben. I have NO IDEA whether you made a mistake or not, but I can  
tell you that at least that, I tested and it is working correctly :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5188 by [hidden email]: Fast Drag doesn't work  
anymore
http://code.google.com/p/pharo/issues/detail?id=5188

Cool :)

But I know that Igor is fighting against direct references to Sensor, so :s


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 5188 by marianopeck: Fast Drag doesn't work anymore
http://code.google.com/p/pharo/issues/detail?id=5188

Hi ben. I found a problem with your fix. Now the drag works, but if you try  
to resize a windows (say make it higher), it doesn't work, I can move the  
edges...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 5188 by [hidden email]: Fast Drag doesn't work  
anymore
http://code.google.com/p/pharo/issues/detail?id=5188

You mean that you do not want to be able to change the size ?

I don't get it :s


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5188 by marianopeck: Fast Drag doesn't work anymore
http://code.google.com/p/pharo/issues/detail?id=5188

I mean that after including your change, I want to resize a windows but it  
doesn't work.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 5188 by [hidden email]: Fast Drag doesn't work  
anymore
http://code.google.com/p/pharo/issues/detail?id=5188

It works in a fresh image #14296 ...

Can you reproduce it ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 5188 by marianopeck: Fast Drag doesn't work anymore
http://code.google.com/p/pharo/issues/detail?id=5188

Yes, I can. But I forgot to say that I should enable fast dragging in order  
to reproduce it:  UITheme currentSettings fastDragging: true.
and then try to resize a windows.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 5188 by [hidden email]: Fast Drag doesn't work  
anymore
http://code.google.com/p/pharo/issues/detail?id=5188

It's exactly what I have done :s

Is your image a fresh one ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 5188 by marianopeck: Fast Drag doesn't work anymore
http://code.google.com/p/pharo/issues/detail?id=5188

yes, I fresh one :(


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.4

Comment #17 on issue 5188 by [hidden email]: Fast Drag doesn't work  
anymore
http://code.google.com/p/pharo/issues/detail?id=5188

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #18 on issue 5188 by [hidden email]: Fast Drag doesn't work  
anymore
http://code.google.com/p/pharo/issues/detail?id=5188

Sorry Mariano but I can't reproduce it :(


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #19 on issue 5188 by marianopeck: Fast Drag doesn't work anymore
http://code.google.com/p/pharo/issues/detail?id=5188

No problem. Thanks for the effort anyway Ben.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker