Issue 5189 in pharo: DNU when not using accessor in Slider and subclasses

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4

New issue 5189 by [hidden email]: DNU when not using accessor in  
Slider and subclasses
http://code.google.com/p/pharo/issues/detail?id=5189

Slider still has the #setValueSelector: methods, but if you use the  
#accessor: one, the inst var for the first one stays in nil, and then, the  
following method breaks:

setValue: newValue
        "Called internally for propagation to model"
        self value: newValue.
       

        accessor ifNotNil: [
                ^ model perform: accessor asMutator with: value
                ].
       
        ^model perform: setValueSelector with: value


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5189 by [hidden email]: DNU when not using  
accessor in Slider and subclasses
http://code.google.com/p/pharo/issues/detail?id=5189

This should be a temporal fix while the setValueSelector is deprecated or  
removed (or not).

setValue: newValue
        "Called internally for propagation to model"
        self value: newValue.
       

        accessor ifNotNil: [
                ^ model perform: accessor asMutator with: value
                ].
       
        setValueSelector ifNotNil: [
                ^model perform: setValueSelector with: value
                ].


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 5189 by [hidden email]: DNU when not using  
accessor in Slider and subclasses
http://code.google.com/p/pharo/issues/detail?id=5189

a slice in the inbox

Name:  
SLICE-Issue-5189-DNU-when-not-using-accessor-in-Slider-and-subclasses-GuillermoPolito.1
Author: GuillermoPolito
Time: 17 January 2012, 12:10:57 pm
UUID: b4ed1077-535c-4d9c-bbcd-c8d0f2770068
Ancestors:
Dependencies: Morphic-GuillermoPolito.1071


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5189 by [hidden email]: DNU when not using  
accessor in Slider and subclasses
http://code.google.com/p/pharo/issues/detail?id=5189

Thanks! I will integrate it soon.Would be good to clean this logic.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 5189 by [hidden email]: DNU when not using  
accessor in Slider and subclasses
http://code.google.com/p/pharo/issues/detail?id=5189

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #5 on issue 5189 by [hidden email]: DNU when not using  
accessor in Slider and subclasses
http://code.google.com/p/pharo/issues/detail?id=5189

in 14287


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker