Issue 5192 in pharo: 0 is not a power of two

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4 Milestone-1.3.1

New issue 5192 by [hidden email]: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

Fix isPowerOfTwo.

Also, implement the protocol on Fraction, and cleanup some checks in  
methods which used to guard against 0 returning true.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Issue 5192: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

This issue is now blocking issue 5005.
See http://code.google.com/p/pharo/issues/detail?id=5005

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5192 by marianopeck: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

Just to sync Henry...are you gonna publish a fix or I try to do it ?

Thanks!!!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5192 by [hidden email]: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

I'll work on it, shouldn't take too long.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5192 by [hidden email]: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

Hmm, implementing it on Fraction sort of raises a whole new can of  
questions...
What should 0 largerPowerOfTwo really return for example?
IMHO, the most correct answer would be raising a DomainError, in which case  
we still need to 0-guard the MethodDict growMethod in Issue 5005 , but in a  
different place:
(numberOfElements * 4 // 3 max: 1) asLargerPowerOfTwo

Is that OK for you Mariano?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Issue 5192: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

This issue is no longer blocking issue 5005.
See http://code.google.com/p/pharo/issues/detail?id=5005
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5192 by marianopeck: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

"the max: 1 is because even empty MethodDictionaries should have one  
slot"  ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5192 by marianopeck: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

sorry....wrong answer..for anotehr issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #8 on issue 5192 by [hidden email]: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

SLICE-Issue-5192-ZeroNotPowerOfTwo-HenrikSperreJohansen.1 in Inbox.

- Fixes 0 isPowerOfTwo
- Introduces DomainError for Integer >> larger/smallerPowerOfTwo when  
receiver is invalid.
- Implements *PowerOfTwo protocol for Fractions.
- Updated tests and added missing ones
- DomainErrors now come with a default messageText, and a class comment  
explaining when to specify your own


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5192 by [hidden email]: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

Thanks Henrik!!



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 5192 by [hidden email]: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

in 14289


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed
        Labels: -Milestone-1.3.1

Comment #11 on issue 5192 by [hidden email]: 0 is not a power of two
http://code.google.com/p/pharo/issues/detail?id=5192

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker