Issue 5197 in pharo: All the methods in convenience-browsing in ToolRegistry should be deprecated.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5197 in pharo: All the methods in convenience-browsing in ToolRegistry should be deprecated.

pharo
Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4 Type-Cleanup Importance-High Difficulty-Easy

New issue 5197 by [hidden email]: All the methods in  
convenience-browsing in ToolRegistry should be deprecated.
http://code.google.com/p/pharo/issues/detail?id=5197

for a full description read issue 4913.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5197 in pharo: All the methods in convenience-browsing in ToolRegistry should be deprecated.

pharo
Issue 5197: All the methods in convenience-browsing in ToolRegistry should  
be deprecated.
http://code.google.com/p/pharo/issues/detail?id=5197

This issue is now blocking issue 4913.
See http://code.google.com/p/pharo/issues/detail?id=4913

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5197 in pharo: All the methods in convenience-browsing in ToolRegistry should be deprecated.

pharo
In reply to this post by pharo
Updates:
        Status: FixReviewNeeded

Comment #2 on issue 5197 by [hidden email]: All the methods in  
convenience-browsing in ToolRegistry should be deprecated.
http://code.google.com/p/pharo/issues/detail?id=5197

i submitted a slice, please review it because some of the code ended up in  
the clients.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5197 in pharo: All the methods in convenience-browsing in ToolRegistry should be deprecated.

pharo

Comment #3 on issue 5197 by [hidden email]: All the methods in  
convenience-browsing in ToolRegistry should be deprecated.
http://code.google.com/p/pharo/issues/detail?id=5197

Thanks
I just changed

browseVersions
        "Browse the method versions."

        | aClass aSelector |
        aClass := self selectedChangeWrapper actualClass.
        aSelector := self selectedMessageName ifNil: [^self].
        Smalltalk tools versionBrowser
                        browseVersionsOf: (aClass compiledMethodAt: aSelector)
                        class: aClass theNonMetaClass
                        meta: aClass isMeta
                        category: (aClass organization categoryOfElement: aSelector)
                        selector: aSelector.

into

browseVersions
        "Browse the method versions."

        | aClass aSelector |
        aClass := self selectedChangeWrapper actualClass.
        aSelector := self selectedMessageName ifNil: [^self].
        Smalltalk tools versionBrowser
                        browseVersionsForClass: aClass selector: aSelector
                       


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5197 in pharo: All the methods in convenience-browsing in ToolRegistry should be deprecated.

pharo
Updates:
        Status: Closed

Comment #4 on issue 5197 by [hidden email]: All the methods in  
convenience-browsing in ToolRegistry should be deprecated.
http://code.google.com/p/pharo/issues/detail?id=5197

in 14290


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker