Issue 5202 in pharo: Implement fast Object >> #split: for single elements

Status: Accepted
Owner: [hidden email]

New issue 5202 by [hidden email]: Implement fast Object >> #split:  
for single elements
http://code.google.com/p/pharo/issues/detail?id=5202


$/ split: 'asdf'

can be implemented 2 times faster by relying on the fact that the needle is  
a not a collection.

Report for: SplitBenchmark
Benchmark SplitSingle
SplitSingle total: iterations=100 runtime: 3.54ms +/-0.20

Benchmark Split
Split total: iterations=100 runtime: 6.89ms +/-0.20








_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5202 by [hidden email]: Implement fast Object >>  
#split: for single elements
http://code.google.com/p/pharo/issues/detail?id=5202

see  
SLICE-Issue-5202-Implement-fast-Object--split-for-single-elements-CamilloBruni.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 5202 by [hidden email]: Implement fast Object >>  
#split: for single elements
http://code.google.com/p/pharo/issues/detail?id=5202#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #3 on issue 5202 by [hidden email]: Implement fast Object >>  
#split: for single elements
http://code.google.com/p/pharo/issues/detail?id=5202#c3

Test Results:
-------------
Errors:
        FractionTest>>#testAsLargerPowerOfTwo
        FractionTest>>#testAsSmallerPowerOfTwo
        FractionTest>>#testIsPowerOfTwo
        IntegerTest>>#testAsLargerPowerOfTwo
        IntegerTest>>#testAsSmallerPowerOfTwo
        FractionTest>>#testAsLargerPowerOfTwo
        FractionTest>>#testAsSmallerPowerOfTwo
        FractionTest>>#testIsPowerOfTwo
        IntegerTest>>#testAsLargerPowerOfTwo
        IntegerTest>>#testAsSmallerPowerOfTwo
Failures:
        IntegerTest>>#testIsPowerOfTwo
        IntegerTest>>#testIsPowerOfTwo

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-5202-Implement-fast-Object--split-for-single-elements-CamilloBruni.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-1.4-14296-a on StackInterpreter  
VMMaker-oscog-EstebanLorenzano.139 uuid:  
5aa53979-d7d8-4ca3-91fe-cfc3b4109c33 Nov 12 2011, nil,  
https://git.gitorious.org/~estebanlm/cogvm/cog-osx.git Commit:  
9072d944a978a31ca36c61acb54dd87494676f20 Date: Sat Nov 12 13:26:17 2011  
-0300 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 5202 by [hidden email]: Implement fast Object >>  
#split: for single elements
http://code.google.com/p/pharo/issues/detail?id=5202#c4

This Issue has been checked by Ulysse the Monkey
       
Test Results:
-------------
Passed: 7424
        CollectionsTests-Arrayed (562)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (593)
        CollectionsTests-Support (12)
        CollectionsTests-Text (40)
        CollectionsTests-Unordered (1972)
        CollectionsTests-Weak (747)
        CompilerTests (28)
        KernelTests-Chronology (1156)
        KernelTests-Classes (136)
        KernelTests-Exception (5)
        KernelTests-Methods (354)
        KernelTests-Numbers (518)
        KernelTests-Objects (170)
        KernelTests-Pragmas (6)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (77)

Errors: 10
        FractionTest>>#testAsLargerPowerOfTwo
        FractionTest>>#testAsSmallerPowerOfTwo
        FractionTest>>#testIsPowerOfTwo
        IntegerTest>>#testAsLargerPowerOfTwo
        IntegerTest>>#testAsSmallerPowerOfTwo
        FractionTest>>#testAsLargerPowerOfTwo
        FractionTest>>#testAsSmallerPowerOfTwo
        FractionTest>>#testIsPowerOfTwo
        IntegerTest>>#testAsLargerPowerOfTwo
        IntegerTest>>#testAsSmallerPowerOfTwo
Failures: 2
        IntegerTest>>#testIsPowerOfTwo
        IntegerTest>>#testIsPowerOfTwo

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-5202-Implement-fast-Object--split-for-single-elements-CamilloBruni.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-1.4-14296-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.139 uuid:  
5aa53979-d7d8-4ca3-91fe-cfc3b4109c33 Dec  4 2011,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.139 uuid:  
5aa53979-d7d8-4ca3-91fe-cfc3b4109c33 Dec  4 2011,  
https://git.gitorious.org/~estebanlm/cogvm/cog-osx.git Commit:  
ba737db8e171ade42fc4a493ffe1b3a5ec1ed397 Date: Sat Dec 3 21:56:37 2011  
-0300 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5202 by [hidden email]: Implement fast Object >>  
#split: for single elements
http://code.google.com/p/pharo/issues/detail?id=5202

seems like it didn't properly merge with the Version of Core containing the  
isPowerOfTwo changes?
Does ulysses simply load the Slice instead of merging?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5202 by [hidden email]: Implement fast Object >>  
#split: for single elements
http://code.google.com/p/pharo/issues/detail?id=5202

that was strange. Ulysse merges changes in, but this time I  either didn't  
update or accidentally changed some other code.
- updated the slice


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.4

Comment #7 on issue 5202 by [hidden email]: Implement fast Object >>  
#split: for single elements
http://code.google.com/p/pharo/issues/detail?id=5202

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #8 on issue 5202 by [hidden email]: Implement fast Object >>  
#split: for single elements
http://code.google.com/p/pharo/issues/detail?id=5202

in 14311


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker