Issue 5217 in pharo: LanguageEnvironment should cache converters

Status: Accepted
Owner: [hidden email]

New issue 5217 by [hidden email]: LanguageEnvironment should cache  
converters
http://code.google.com/p/pharo/issues/detail?id=5217

LanguageEnvironment caches the classes instead of instances causing  
significant overhead.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

see
  SLICE-Issue-5217-LanguageEnvironment-should-cache-converters-CamilloBruni.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Labels: Milestone-1.4

Comment #2 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #3 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

in 14296


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #4 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

Vm Crash when merging the Slice


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #5 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217#c5

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #6 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217#c6

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-5217-LanguageEnvironment-should-cache-converters-CamilloBruni.1  
from http://ss3.gemstone.com/ss/PharoInbox:
        Warning: You are about to load new versions of the following packages that  
have unsaved changes in the image.  If you continue, you will lose these  
changes.

   KernelTests
   KernelTests
  1: MCVersionLoader(Object)>>notify:
  2: MCVersionLoader>>warnAboutLosingChangesTo:
  3: MCVersionLoader>>checkForModifications
  4: MCVersionLoader>>loadWithNameLike:
  5: MCVersionLoader>>load
  6: GoferLoad>>execute
  7: Gofer>>execute:do:
  8: Gofer>>execute:
  9: Gofer>>load
10: GoferResolvedReference>>load
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-5217-LanguageEnvironment-should-cache-converters-CamilloBruni.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-1.4-14296-a on StackInterpreter  
VMMaker-oscog-EstebanLorenzano.139 uuid:  
5aa53979-d7d8-4ca3-91fe-cfc3b4109c33 Nov 12 2011, nil,  
https://git.gitorious.org/~estebanlm/cogvm/cog-osx.git Commit:  
9072d944a978a31ca36c61acb54dd87494676f20 Date: Sat Nov 12 13:26:17 2011  
-0300 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #7 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

the slice has to be loaded manually since it will recompile FileStream  
which most probably is used by the running system...

Loading first the changes on LanguageEnvironment and then the rest worked  
for me, otherwise I get a crash.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #9 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

The idea is to have "fixToInclude" be issues that can be integrated without  
thinking.

This means, if it is a two step manual process, it needs multiple slices  
(or .cs) and a step by step description.

Else the integrator burns a lot of energy...

(I think we need to automatize integration just for people to not have an  
excuse to delegate "trivialities" to to integrator... if it would be  
automatic, it would be clear that e.g. a textual description of code is not  
equal to real code...)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

I totally agree. so we *HAVE* to use the Monkey! and the integrator  
script/image ben wrote... there is no future in doing the whole integration  
process manually :/


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

Yes!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Enh

Comment #13 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.4 Milestone-1.5

Comment #14 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

"Loading first the changes on LanguageEnvironment and then the rest worked  
for me, otherwise I get a crash."

So we should produce two fixes. I tagged it as 1.5


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #16 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

need to be splited into two fixes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #17 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #18 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

Changeset loads on latest image without problems.

Attachments:
        languageEnvironment.cs  1.9 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #19 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #20 on issue 5217 by [hidden email]: LanguageEnvironment  
should cache converters
http://code.google.com/p/pharo/issues/detail?id=5217

in 3.0 310

(doing an update with changesets that makes the image dirty)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker