Issue 5227 in pharo: NonInteractiveUIManager should implement #syntaxErrorNotificationDefaultAction:

Status: Accepted
Owner: ----
Labels: Milestone-1.4 Type-Feature

New issue 5227 by [hidden email]: NonInteractiveUIManager should  
implement #syntaxErrorNotificationDefaultAction:
http://code.google.com/p/pharo/issues/detail?id=5227

Right now, when there is a syntax error in a startup script running  
headless,
NonInteractiveUIManager will signal a ErrorNonInteractive, log that as such  
and quit,
but it would be better and more helpful to really handle the syntax error  
by reporting it
as clear as possible to the log and then quit as before.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5227 by [hidden email]: NonInteractiveUIManager  
should implement #syntaxErrorNotificationDefaultAction:
http://code.google.com/p/pharo/issues/detail?id=5227

OK, what about

NonInteractiveUIManager>>syntaxErrorNotificationDefaultAction: exception
     exception pass

this should just let the exception (assumed to be a syntax error) be  
handled the same way as #nonInteractive, i.e. being logged and the image  
quited.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5227 by [hidden email]: NonInteractiveUIManager  
should implement #syntaxErrorNotificationDefaultAction:
http://code.google.com/p/pharo/issues/detail?id=5227

I will push the changes from issue #5176 to here, I guess makes more sense.
The current implementation will highlight and output syntax errors on  
stderr in the following format:

file:///Users/cami-data/education/phd/project/pharo/scriptCompilerWarning/script.st
Syntax Error on line 4: 'Argument expected'
===========================================
1:
2: (Smalltalk image
3:     at: 1 put: 2;
4:     name) | | with: 1.
               _^_



With the new error reporting mechanisms we get at least some notification  
if a script fails.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5227 by [hidden email]: NonInteractiveUIManager  
should implement #syntaxErrorNotificationDefaultAction:
http://code.google.com/p/pharo/issues/detail?id=5227

I made a huge slice with various fixes for this :)

SLICE-Issue-5227-NonInteractiveUIManager-should-implement-syntaxErrorNotificationDefaultAction-CamilloBruni.1

can someone have a look at the implications, I presume that most of the  
users won't be affected


============================================================

Primarily fixed startup errors for loaded scripts

- CodeLoader prints out SyntaxErrors and the filename if a script fails to  
load

- added CommandLineUIManager which should be an interactive implementation  
for being used on the terminal

- NonInteractiveUIManager inherits from CommandLineUIManager so that the  
logging facility can be shared

- Cleaned up SyntaxError
        - added direct initializers with SyntaxErrorNotification:
        - properly color the displayed code
        - selec the error message
        - display the error message in the title
        - double click on the class name opens the debugger

- Cleaned up users of SyntaxErrorNotification:
        - provide the code in raw format without included error message

- changed the notion of headless and interactive on SmalltalkImage
        - headless == no display attached
        - noninteractive == no user input (previously the negation of headless)
        - added new possible commmandline option -interactive

- added convenience method in String >> #lineNumberCorrespondingToIndex:  
used for formatting the syntax errors


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5227 by [hidden email]: NonInteractiveUIManager  
should implement #syntaxErrorNotificationDefaultAction:
http://code.google.com/p/pharo/issues/detail?id=5227

Issue 5176 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5227 by [hidden email]: NonInteractiveUIManager  
should implement #syntaxErrorNotificationDefaultAction:
http://code.google.com/p/pharo/issues/detail?id=5227

Niceeeee! :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5227 by [hidden email]: NonInteractiveUIManager  
should implement #syntaxErrorNotificationDefaultAction:
http://code.google.com/p/pharo/issues/detail?id=5227

Yes, very nice indeed !

Are TestMorph>>#yellowButtonActivity: and PasteUpMorph>>#mouseDown: part of  
this patch ?

These strike me a suspect.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5227 by [hidden email]: NonInteractiveUIManager  
should implement #syntaxErrorNotificationDefaultAction:
http://code.google.com/p/pharo/issues/detail?id=5227

they accidentally slipped in... AFAIK they are the exact same version as in  
the existing pharo...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5227 by [hidden email]: NonInteractiveUIManager  
should implement #syntaxErrorNotificationDefaultAction:
http://code.google.com/p/pharo/issues/detail?id=5227

If youi say so, in my Pharo1.4a, Latest update: #14323 they were marked as  
new...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #9 on issue 5227 by [hidden email]: NonInteractiveUIManager  
should implement #syntaxErrorNotificationDefaultAction:
http://code.google.com/p/pharo/issues/detail?id=5227

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 5227 by [hidden email]: NonInteractiveUIManager  
should implement #syntaxErrorNotificationDefaultAction:
http://code.google.com/p/pharo/issues/detail?id=5227

in 14326


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker