Issue 5251 in pharo: Remove MCWorkingCopy from startup list

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5251 in pharo: Remove MCWorkingCopy from startup list

pharo
Status: FixToInclude
Owner: marianopeck
Labels: Milestone-1.4

New issue 5251 by marianopeck: Remove MCWorkingCopy from startup list
http://code.google.com/p/pharo/issues/detail?id=5251

MCWorkingCopy is in Smalltalk startUp list but it doesn't implement  
#startUp and hence it uses the empty version of Behavior. It should be  
removed:

Smalltalk removeFromStartUpList: MCWorkingCopy




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5251 in pharo: Remove MCWorkingCopy from startup list

pharo
Updates:
        Status: Integrated

Comment #1 on issue 5251 by [hidden email]: Remove MCWorkingCopy  
from startup list
http://code.google.com/p/pharo/issues/detail?id=5251

in 14316


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5251 in pharo: Remove MCWorkingCopy from startup list

pharo
Updates:
        Status: Accepted
        Cc: [hidden email]

Comment #2 on issue 5251 by marianopeck: Remove MCWorkingCopy from startup  
list
http://code.google.com/p/pharo/issues/detail?id=5251

Grrrr sorry Marcus, now I realised it was not implementing #startUp but  
#startUp:  :(   hence it looks like it should come back :(   the #startUp:  
is:

startUp: resuming
        "Ensure Monticello is receiving system change notifications."

        resuming ifTrue:
                [Smalltalk globals
                        at: #SystemChangeNotifier
                        ifPresent: [:scn| self reregisterForNotificationsWith: scn  
uniqueInstance]]


What I am not sure if that is required or not. Cami?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5251 in pharo: Remove MCWorkingCopy from startup list

pharo

Comment #3 on issue 5251 by marianopeck: Remove MCWorkingCopy from startup  
list
http://code.google.com/p/pharo/issues/detail?id=5251

BTW...I did the following scripts..

| classes aClass |
classes := OrderedCollection new.
(SmalltalkImage classVarNamed: 'StartUpList') do: [:each |
        aClass := Smalltalk at: each.
                aClass isBehavior
                        ifTrue: [((( aClass class lookupSelector: #startUp:) methodClass ==  
Behavior) and: [(( aClass class lookupSelector: #startUp) methodClass ==  
Behavior)])
                                ifTrue: [classes add: aClass  ]].
        ].
classes

And:


| classes aClass |
classes := OrderedCollection new.
(SmalltalkImage classVarNamed: 'ShutDownList') do: [:each |
        aClass := Smalltalk at: each.
                aClass isBehavior
                        ifTrue: [((( aClass class lookupSelector: #shutDown:) methodClass ==  
Behavior) and: [(( aClass class lookupSelector: #shutDown) methodClass ==  
Behavior)])
                                ifTrue: [classes add: aClass  ]].
        ].
classes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5251 in pharo: Remove MCWorkingCopy from startup list

pharo
Updates:
        Cc: renggli

Comment #4 on issue 5251 by marianopeck: Remove MCWorkingCopy from startup  
list
http://code.google.com/p/pharo/issues/detail?id=5251

What I mean is why would Metacello need to reregister in the startUp?  
otherwise, all classes that need notitifcations should also being  
reregister at startup. And they look like of they do not do it. Is there  
something special with Monticello?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5251 in pharo: Remove MCWorkingCopy from startup list

pharo

Comment #5 on issue 5251 by renggli: Remove MCWorkingCopy from startup list
http://code.google.com/p/pharo/issues/detail?id=5251

I guess it is just a security measure; or it was needed for the old  
change-notification system that is in parts still present.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5251 in pharo: Remove MCWorkingCopy from startup list

pharo
Updates:
        Labels: Type-Cleanup

Comment #6 on issue 5251 by [hidden email]: Remove MCWorkingCopy  
from startup list
http://code.google.com/p/pharo/issues/detail?id=5251

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5251 in pharo: Remove MCWorkingCopy from startup list

pharo
Updates:
        Status: Closed

Comment #7 on issue 5251 by [hidden email]: Remove MCWorkingCopy  
from startup list
http://code.google.com/p/pharo/issues/detail?id=5251

As all the others do not re-register on startup, we should just remove it.

Issue 5429 does that, with some other cleanup.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker