Issue 5280 in pharo: MCClassDefinition>>source

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5280 in pharo: MCClassDefinition>>source

pharo
Status: FixReviewNeeded
Owner: [hidden email]

New issue 5280 by [hidden email]: MCClassDefinition>>source
http://code.google.com/p/pharo/issues/detail?id=5280

ul et al proposed in squeak the following: that class comment gets taken  
into account as source of the class.

MCClassDefinition>>source
        ^ self definitionAndCommentString

MCClassDefinition>>definitionAndCommentString
        ^ String streamContents: [:stream |
                self printDefinitionOn: stream.
                stream cr; cr.
                self printClassSideDefinitionOn: stream.
                stream cr; cr.
                self printCommentOn: stream]


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5280 in pharo: MCClassDefinition>>source

pharo
Updates:
        Labels: Type-Bug Milestone-1.4

Comment #1 on issue 5280 by [hidden email]: MCClassDefinition>>source
http://code.google.com/p/pharo/issues/detail?id=5280

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5280 in pharo: MCClassDefinition>>source

pharo
Updates:
        Status: Workneeded

Comment #2 on issue 5280 by [hidden email]: MCClassDefinition>>source
http://code.google.com/p/pharo/issues/detail?id=5280

next step: Slice or cs. Copy and paste is so much work that nobody will  
review this.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5280 in pharo: MCClassDefinition>>source

pharo
Updates:
        Labels: -Milestone-1.4

Comment #3 on issue 5280 by [hidden email]: MCClassDefinition>>source
http://code.google.com/p/pharo/issues/detail?id=5280

Not a show stopper for releasing 1.4. (but *if* someone posts code, we are  
happy to consider it to 1.4.. but nobody needs to stay awake and fix it  
before we can release 1.4)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5280 in pharo: MCClassDefinition>>source

pharo
Updates:
        Cc: [hidden email]

Comment #4 on issue 5280 by marianopeck: MCClassDefinition>>source
http://code.google.com/p/pharo/issues/detail?id=5280

Stef, notice that with that change, you don't only add the comment but also  
the class side....I am not sure the impact about that. So far we have:

MCClassDefinition >> definitionString
        ^ String streamContents: [:stream | self printDefinitionOn: stream]
       

But your code does:

self printDefinitionOn: stream.
                stream cr; cr.
                self printClassSideDefinitionOn: stream.

so I am not sure....

anyone?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5280 in pharo: MCClassDefinition>>source

pharo
Updates:
        Status: WorkNeeded

Comment #5 on issue 5280 by [hidden email]: MCClassDefinition>>source
http://code.google.com/p/pharo/issues/detail?id=5280

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5280 in pharo: MCClassDefinition>>source

pharo
Updates:
        Status: Closed

Comment #6 on issue 5280 by [hidden email]: MCClassDefinition>>source
http://code.google.com/p/pharo/issues/detail?id=5280

I tried out and I do not see the benefice of this changes so I close it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5280 in pharo: MCClassDefinition>>source

pharo

Comment #7 on issue 5280 by [hidden email]: MCClassDefinition>>source
http://code.google.com/p/pharo/issues/detail?id=5280

Now I tthink that this is visible in the merge tool.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker