Issue 5281 in pharo: Refactor in LazyListMorph

Status: FixReviewNeeded
Owner: [hidden email]
Labels: Type-Cleanup Milestone-1.4 Difficulty-Easy

New issue 5281 by [hidden email]: Refactor in LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

First it avoids a isText message, and instead delegates to the item.
Due to that, LazyMorph can render every kind of objects now, with the same  
number of message sends :)


Due to that, we should be able to easily flatten the LazyListMorph  
hierarchy since LazyMorphListMorph is kind of useless now, and  
MulticolumnLazyListMorph too (I will think about a proper wrapper for  
generating the multi columns) :)


The cs is in two steps:
     - I implement the method (RefactorInLazyListMorphPart1.2.cs)
     - I modify LazyListMorph to call it (RefactorInLazyListMorphPart2.2.cs)

Tested on:
     Pharo1.4a
     Latest update: #14328

Attachments:
        RefactorInLazyListMorphPart1.2.cs  30.2 KB
        RefactorInLazyListMorphPart2.2.cs  667 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5281 by [hidden email]: Refactor in LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

Also add an indirection to delegate the calculation of the width of each  
item.

Use these cs files instead of previous ones



Attachments:
        RefactorInLazyListMorphPart1.3.cs  30.9 KB
        RefactorInLazyListMorphPart2.3.cs  5.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5281 by [hidden email]: Refactor in LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

Could we avoid to add method to Object? I guess that in this case this is  
possible. Ideally I would love to have only Morphs in UI not objects.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5281 by [hidden email]: Refactor in LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

Ben you mean that LazyMorphListMorph is just when object are Morph while  
the other LazyListMorph was to handle non morph objects?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5281 by [hidden email]: Refactor in LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

The method on Object is in case of providing the wrong object, you do not  
break everything, you got something displayed. But you can easily remove  
it, it shouldn't be used anyway :)

And yes, LazyMorphListMorph is to display morphs when LazyListMorph can  
only handle strings and texts


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5281 by [hidden email]: Refactor in LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

A cs file which remove the methods from Object

Attachments:
        RefactorInLazyListMorphPart1.4.cs  24.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5281 by [hidden email]: Refactor in LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

in 14332


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: closed

Comment #7 on issue 5281 by [hidden email]: Refactor in LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5281 by [hidden email]: Refactor in LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

Ben when I load RefactorInLazyListMorphPart1.4.cs  and  
RefactorInLazyListMorphPart2.3.cs
opening monticello browser does not (when clicking on a repository + open).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #9 on issue 5281 by [hidden email]: Refactor in LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 5281 by [hidden email]: Refactor in  
LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

I got this issue then fixed it, maybe I posted here the wrong version


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #11 on issue 5281 by [hidden email]: Refactor in  
LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

Here is the cs to apply in addition of the previous ones.
It was ready, but I forgot to post it.

Sorry

Attachments:
        FixInTextMethod.1.cs  1.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5281 by [hidden email]: Refactor in  
LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

Another one in addition of all the other.

Fix a bug which never occurs til now :)
By the way, the Pharo version 14322 doesn't work til this issue is  
integrated :s

Attachments:
        FixInMultiColumn.1.cs  720 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 5281 by [hidden email]: Refactor in  
LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

And another to fix the Morphs.
It works, but you can't interact with Morphs.

Now you can :)
(Still in addition)

Attachments:
        MorphLazyList.1.cs  331 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: closed

Comment #15 on issue 5281 by [hidden email]: Refactor in  
LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

ok in 14333


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #16 on issue 5281 by [hidden email]: Refactor in  
LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

Are you sure it's in the system ?

Cause there is no sender nor implementor of widthToDisplayInList: by example


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #17 on issue 5281 by [hidden email]: Refactor in  
LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

you mean in 14333.
Benjamin cses do not work. Believe me. I had to check the conflicts by hand  
and since I do not know the code I have to compare by hand the two  
MorphLazyList.... Tedious.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #18 on issue 5281 by [hidden email]: Refactor in  
LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

so where is the missing code?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #19 on issue 5281 by [hidden email]: Refactor in  
LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

when I load the cs it works.

It seams to disappear during the integration process

I will do a slice then
(it's hard to do a slice for me since I hack a lot around before finding  
where to add changes, so a lot of classes a dirty without any reason ^^)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #20 on issue 5281 by [hidden email]: Refactor in  
LazyListMorph
http://code.google.com/p/pharo/issues/detail?id=5281

Slice done.
Hope it works

(Strangely it seems that when the changeset about PluggableList is loaded,  
it reverts the changes in the cs of this issue :s)

I will really try to focus on slice instead of cs !! Do not hesitate to  
harass me if needed ^^


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker