Issue 5305 in pharo: cannot filein an entire file

Status: Accepted
Owner: ----
Labels: Milestone-1.4 Type-Bug

New issue 5305 by [hidden email]: cannot filein an entire file
http://code.google.com/p/pharo/issues/detail?id=5305

Pharo image: Pharo1.4a#14333
Virtual machine used: CoInterpreter VMMaker-oscog-EstebanLorenzano.139  
uuid: 5aa53979-d7d8-4ca3-91fe-cfc3b4109c33 Dec 11 2011,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.139 uuid:  
5aa53979-d7d8-4ca3-91fe-cfc3b4109c33 Dec 11 2011,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
364a7f1fab69798c1bdc9575ba15e18ea319585a Date: Sun Dec 11 15:17:52 2011  
-0300 By: Esteban Lorenzano <[hidden email]>
Platform Name: unix
Class browser used (if applicable): Browser

Steps to reproduce:
#.World>>Tools>>File Browser
#.select a changeset file
#.right click on contents >> FileIn entire file
Actual Result:
#.MNU: ByteString>>fullName
Expected Result:
#. filein entire file


Attachments:
        PharoDebug.log  32.6 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5305 by [hidden email]: cannot filein an entire  
file
http://code.google.com/p/pharo/issues/detail?id=5305

I attached a cs that fix the problem.


I did not modify the following method:

SimpleServiceEntry>>getArgumentsFrom: aProvider
        argumentGetter ifNil: [^aProvider fullName].
        ^argumentGetter value: aProvider


because I do not know if aProvider should answer fullName or not...

What I did instead is modifying how SimpleServiceEntry instances are  
created by adding an right argumentGetter block:

serviceFileIn
        "Answer a service for filing in an entire file"
        ^ (SimpleServiceEntry
                provider: self
                label: 'FileIn entire file'
                selector: #fileIn:
                description: 'File in the entire decompressed contents of the file, which  
is expected to contain Smalltalk code in fileout ("chunk") format'
                buttonLabel: 'Filein')
                argumentGetter: [ :filePath | filePath ];
                yourself



Attachments:
        fix5305.1.cs  1.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5305 by [hidden email]: cannot filein an entire  
file
http://code.google.com/p/pharo/issues/detail?id=5305

that's not the real problem... I have a fix ready in short.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5305 by [hidden email]: cannot filein an entire  
file
http://code.google.com/p/pharo/issues/detail?id=5305

sorry might be wrong ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5305 by [hidden email]: cannot filein an entire  
file
http://code.google.com/p/pharo/issues/detail?id=5305

should be fixed in

  SLICE-Issue-5301-cannot-install-changeset-CamilloBruni.2


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5305 by [hidden email]: cannot filein an entire  
file
http://code.google.com/p/pharo/issues/detail?id=5305

Issue 5304 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5305 by [hidden email]: cannot filein an entire  
file
http://code.google.com/p/pharo/issues/detail?id=5305

Issue 5303 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5305 by [hidden email]: cannot filein an entire  
file
http://code.google.com/p/pharo/issues/detail?id=5305

Issue 5302 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5305 by [hidden email]: cannot filein an entire  
file
http://code.google.com/p/pharo/issues/detail?id=5305

Issue 5301 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #9 on issue 5305 by [hidden email]: cannot filein an entire  
file
http://code.google.com/p/pharo/issues/detail?id=5305

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 5305 by [hidden email]: cannot filein an entire  
file
http://code.google.com/p/pharo/issues/detail?id=5305

in 14334


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker