Issue 5310 in pharo: Ensure registration symmetry in ExternalSemaphoreTable users

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.3 Milestone-1.4

New issue 5310 by [hidden email]: Ensure registration symmetry in  
ExternalSemaphoreTable users
http://code.google.com/p/pharo/issues/detail?id=5310

1) InputEventFetcher, this has been bug-fixed once already. No leaks as  
long as it has a single entry in startup/shutdown lists.
2) Sockets, which, to my knowledge work OK with the weak finalization.
3) AsyncFile, only done correctly if #close'd at EOL. No weak cleanup done  
it seems, could be changed to work like Sockets.
4) StandardFileStream url opening, should be modified to use an ensure:  
block. Only applicable when running in a browser though, unlikely to be a  
large issue.
5) NetNameResolver, never unregisters the semaphore, and leaks one whenever  
network needs (re)initialization. Snapshot? Image quit? Arbitrary points  
during execution? Reading the plugin source would tell the real cases I  
guess.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5310 by [hidden email]: Ensure registration symmetry  
in ExternalSemaphoreTable users
http://code.google.com/p/pharo/issues/detail?id=5310

SLICE-Issue-5310-ExternalSemaphoreSymmetry-HenrikSperreJohansen.1 in the  
Inbox for 1.4.

It alleviates 3) with a better class comment, uses ensure blocks for 4),  
and fixes 5) to the best of my ability.

5) needed some more radical changes to guard against other race conditions  
as well (described in comments in initializeNetwork), and a class  
initialization of NetNameResolver is necessary in the postscript, if  
modifcations to #initialize does not trigger it. (For example, I reused  
HaveNetwork variable for a slightly different purpose, and introduced  
static initialization of ResolverMutex to avoid race conditions during its  
initialization)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 5310 by [hidden email]: Ensure registration symmetry  
in ExternalSemaphoreTable users
http://code.google.com/p/pharo/issues/detail?id=5310

No idea where changes to 1.3 are to be put anymore, so here's the .cs with  
the changes.
If there are any problems, please let me know.

Attachments:
        ExternalSemaphoreSymmetry.1.cs  6.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Bug

Comment #3 on issue 5310 by [hidden email]: Ensure registration  
symmetry in ExternalSemaphoreTable users
http://code.google.com/p/pharo/issues/detail?id=5310

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.4

Comment #4 on issue 5310 by [hidden email]: Ensure registration  
symmetry in ExternalSemaphoreTable users
http://code.google.com/p/pharo/issues/detail?id=5310

in 14352

TODO: 1.3 (after testing it in 1.4)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #5 on issue 5310 by [hidden email]: Ensure registration  
symmetry in ExternalSemaphoreTable users
http://code.google.com/p/pharo/issues/detail?id=5310

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated
        Labels: Milestone-1.4

Comment #6 on issue 5310 by [hidden email]: Ensure registration  
symmetry in ExternalSemaphoreTable users
http://code.google.com/p/pharo/issues/detail?id=5310

in 13325


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker