Issue 5314 in pharo: Broken string morph shadow

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4 Type-Bug

New issue 5314 by [hidden email]: Broken string morph shadow
http://code.google.com/p/pharo/issues/detail?id=5314

With image 1.4 update #14333
The following code produce a broken shadow:

| s|
s := StringMorph contents: 'hello'.
s hasDropShadow: true.
s openInWorld.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5314 by [hidden email]: Broken string morph shadow
http://code.google.com/p/pharo/issues/detail?id=5314

yes i changed shadow drawing to force every morph implement own shadow  
drawing,
and not just draw things normally but via special 'shadow' canvas.

the point is that canvas should not be aware of any such things, like  
shadow.
because if today you using specialized canvas to render shadows, then  
tomorrow you might want to create a canvas for drawing outlines, whatever...
such approach goes nowhere.
so, the fix will be to implement a corresponding method in StringMorph to  
draw the shadow, i.e. use "normal" canvas and send "normal" commands to  
draw the shadow,
but not rely on some canvas which has special shadow-drawing mode.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5314 by [hidden email]: Broken string morph shadow
http://code.google.com/p/pharo/issues/detail?id=5314

Here the implementation.

Try it with following:

| s|
s := StringMorph contents: 'hello'.
s hasDropShadow: true.
s shadowOffset: 3@3.
s shadowColor: (Color black alpha: 0.3).
s openInWorld

because the problem is that by default , a shadow offset is 0@0,
which makes it invisible.

Attachments:
        StringMorph-drawDropShadowOn.st  437 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #3 on issue 5314 by [hidden email]: Broken string morph  
shadow
http://code.google.com/p/pharo/issues/detail?id=5314

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #4 on issue 5314 by [hidden email]: Broken string morph  
shadow
http://code.google.com/p/pharo/issues/detail?id=5314

in 14351


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker