Issue 5328 in pharo: cannot view file contents as encoded text

Status: Accepted
Owner: ----
Labels: Milestone-1.4 Type-Bug

New issue 5328 by [hidden email]: cannot view file contents as  
encoded text
http://code.google.com/p/pharo/issues/detail?id=5328

Pharo image: Pharo1.4a#14339
Virtual machine used: CoInterpreter VMMaker-oscog-EstebanLorenzano.139  
uuid: 5aa53979-d7d8-4ca3-91fe-cfc3b4109c33 Dec 11 2011,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.139 uuid:  
5aa53979-d7d8-4ca3-91fe-cfc3b4109c33 Dec 11 2011,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
364a7f1fab69798c1bdc9575ba15e18ea319585a Date: Sun Dec 11 15:17:52 2011  
-0300 By: Esteban Lorenzano <[hidden email]>
Platform Name: unix
Class browser used (if applicable): Browser

Steps to reproduce:
#.World>>Tools>>File Browser
#.select a changeset file
#.right click on contents >> View as encoded text
#. select an encoding. for instance, utf-8, utf8

Actual Result:
#.MNU: FileList>>utf-8

Expected Result:
#. view file contents as encoded text

Attachments:
        PharoDebug.log  25.8 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5328 by [hidden email]: cannot view file  
contents as encoded text
http://code.google.com/p/pharo/issues/detail?id=5328

did that ever work? I can reproduce the same error in 1.3.. so I vouch for  
removal


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 5328 by [hidden email]: cannot view file  
contents as encoded text
http://code.google.com/p/pharo/issues/detail?id=5328

removal attached

Attachments:
        CleanFileList.1.cs  2.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #3 on issue 5328 by [hidden email]: cannot view file  
contents as encoded text
http://code.google.com/p/pharo/issues/detail?id=5328

Yes sound good to me.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5328 by [hidden email]: cannot view file contents  
as encoded text
http://code.google.com/p/pharo/issues/detail?id=5328

However if it is removed and one chooses to display as hex, there is no  
option to redisplay as text anymore (deselecting and reselecting the file  
is at best a workaround).

The attached changeset prevents the MNU in the "View as encoded text" menu  
option, and even sets an ivar with the user-selected encoding for future  
use ; however encoding is not actually used (don't know how/where...)

Attachments:
        5328-FileListMNUEncoding.2.cs  1.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded
        Labels: -Milestone-1.4

Comment #5 on issue 5328 by [hidden email]: cannot view file  
contents as encoded text
http://code.google.com/p/pharo/issues/detail?id=5328

integrated the last one, put back to work needed and removed 1.4 tag.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5328 by [hidden email]: cannot view file contents  
as encoded text
http://code.google.com/p/pharo/issues/detail?id=5328

New version adds a converter (utf-8 by default) and uses it to display  
either the full text or the shortened version. Error message updated to  
reflect the possibility to pick a different encoding.

Tested with utf-8, iso-8859-1 and -15 and koi-8r sample texts as well as  
attempting to view binary files.

Interestingly enough, on binary files, only the utf-8 decoder barfs ; the  
others display whatever they can.

Attachments:
        5328-FileListMNUEncoding.3.cs  3.1 KB
        Screenshot-FileListWithGrid-koi8.png  107 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #7 on issue 5328 by [hidden email]: cannot view file  
contents as encoded text
http://code.google.com/p/pharo/issues/detail?id=5328

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker