Issue 5329 in pharo: ToolsTest-PointerFinder failing tests

Status: FixReviewNeeded
Owner: [hidden email]

New issue 5329 by [hidden email]:  ToolsTest-PointerFinder  
failing tests
http://code.google.com/p/pharo/issues/detail?id=5329

There are three failing tests in ToolsTest-PointerFinder. The reason of  
assertion failures is presence of closure context from the method  
#pointersToExcept:.

The fix adds a condition to block of removeAllSuchThat: in the body of this  
method that rejects object mentioned closure context. The fixed method code  
includes a warning comment.

Attachments:
        ProtoObject-pointersToExcept.st  1.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.4 Type-Bug

Comment #1 on issue 5329 by [hidden email]:  ToolsTest-PointerFinder  
failing tests
http://code.google.com/p/pharo/issues/detail?id=5329

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5329 by [hidden email]:  ToolsTest-PointerFinder  
failing tests
http://code.google.com/p/pharo/issues/detail?id=5329

Thanks a lot!!!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5329 by marianopeck:  ToolsTest-PointerFinder failing  
tests
http://code.google.com/p/pharo/issues/detail?id=5329

I don't understand the fix nor the problem. When you add:
"(ea == thisContext sender)"   don't we already have thisContext sender  in  
the objectsToAlwaysExclude  ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5329 by [hidden email]:  
ToolsTest-PointerFinder failing tests
http://code.google.com/p/pharo/issues/detail?id=5329

Bacause of real closures, thisContext within the block is not the same  
object as thisContext in the body of the method.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #5 on issue 5329 by marianopeck:  ToolsTest-PointerFinder failing  
tests
http://code.google.com/p/pharo/issues/detail?id=5329

Ahhhhh ok, now I got it. Good catch! thanks Pavel. I change the status


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 5329 by [hidden email]:  ToolsTest-PointerFinder  
failing tests
http://code.google.com/p/pharo/issues/detail?id=5329

in 13241


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker