Issue 5335 in pharo: (Color fromString: #RED) broken

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-1.4 Difficulty-Easy

New issue 5335 by [hidden email]: (Color fromString: #RED) broken
http://code.google.com/p/pharo/issues/detail?id=5335

This is one of the GREASE failing tests

self assert: (Color fromString: 'RED') = Color red.

And the fix is rather easy, it seems an asLowercase was lost in
Color class>>fromString:




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5335 by [hidden email]: (Color fromString: #RED)  
broken
http://code.google.com/p/pharo/issues/detail?id=5335

However, the refactoring also broke another expectation with literal  
sharp...

     self assert: (Color fromString: '#red') = Color red.

It seems that solution of Issue 3432 went beyond squeak refactorings ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5335 by [hidden email]: (Color fromString: #RED)  
broken
http://code.google.com/p/pharo/issues/detail?id=5335

Hi nicolas
from which refactoring are you talking about?

Stef


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5335 by [hidden email]: (Color fromString: #RED)  
broken
http://code.google.com/p/pharo/issues/detail?id=5335

Refactoring made in Issue 3432


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #4 on issue 5335 by [hidden email]: (Color fromString: #RED)  
broken
http://code.google.com/p/pharo/issues/detail?id=5335

My infinitesimal contribution:

Name: SLICE-Issue-5335-Color-class-fromString-broken-nice.1
Dependencies: Graphics-Primitives-nice.70, Graphics-Tests-nice.18

This also solves mixed lower/uppercases (I think Squeak version fails with  
this one):

self assert: (Color fromString: '#darkGray') = Color darkGray.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #5 on issue 5335 by [hidden email]: (Color fromString: #RED)  
broken
http://code.google.com/p/pharo/issues/detail?id=5335

in 14342


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker