Issue 5336 in pharo: MenuRegistration are defined on class side with no link with the calling instance

Status: Accepted
Owner: [hidden email]

New issue 5336 by [hidden email]: MenuRegistration are defined on  
class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

Then I read Guillermo code about Key Mapping, so I tried something :)

Now, when you provide a block (maybe the same should be done for selectors,  
i don't know), instead of just send value, I send cull: and I provide as  
argument the model of the PragmaMenuBuilder



Alain, if you have the time to have a look :)

I attach a slice


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]
        Labels: Type-Feature Milestone-1.4 Nautilus

Comment #1 on issue 5336 by [hidden email]: MenuRegistration are  
defined on class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

Slice is in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5336 by [hidden email]: MenuRegistration are  
defined on class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

Another approach is to provide this information from the PragmaBuilder to  
the ToggleMenuItemMorph and to add the information when the perform is done  
in #invokeWithEvent: (in a same way the event is added)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5336 by [hidden email]: MenuRegistration are  
defined on class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

I did something else, I added the model as an argument to the method  
invoking the menu builder

Attachments:
        NautilusPragmaMenuBuilder.st  1.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5336 by [hidden email]: MenuRegistration are  
defined on class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

But you can already pass the model with
PragmaMenuBuilder class>> pragmaKeyword: aPragmaKeyword model: aModel


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5336 by [hidden email]: MenuRegistration are  
defined on class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

yes indeed, but now I can define a method like:

groupsFixMenu: aBuilder target: target
        <nautilusGroupFixMenu>

        (aBuilder item: #'Find Class... (f)')
                action: [target findClass];
                order: 0;
                help: 'Search for a class by name';
                withSeparatorAfter.

and here, target is the model provided when PragmaMenuBuilder class>>  
pragmaKeyword: aPragmaKeyword model: aModel is called.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #6 on issue 5336 by [hidden email]: MenuRegistration are  
defined on class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #7 on issue 5336 by [hidden email]: MenuRegistration are  
defined on class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

So what is the status of this one? Not clear if what the code is to be  
reviewed


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5336 by [hidden email]: MenuRegistration are  
defined on class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

It's ok for me except that I would integrate the changes directly in  
PragmaMenuBuilder (and not in a new subclass NautilusPragmaMenuBuilder).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5336 by [hidden email]: MenuRegistration are  
defined on class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

Of course, but since I needed it n the midtime, I have done a subclass :)

I will propose a slice :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #10 on issue 5336 by [hidden email]: MenuRegistration are  
defined on class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

Slice in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WontFix

Comment #11 on issue 5336 by [hidden email]: MenuRegistration are  
defined on class side with no link with the calling instance
http://code.google.com/p/pharo/issues/detail?id=5336

After a discussion with Alain, we figure out that it is useless and a wrong  
idea.

you can retrieve the model through the builder
      aBuilder model


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker