Issue 5349 in pharo: remove "findOriginalChangeSet"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5349 in pharo: remove "findOriginalChangeSet"

pharo
Status: FixReviewNeeded
Owner: [hidden email]
Labels: Type-Cleanup Milestone-1.4

New issue 5349 by [hidden email]: remove "findOriginalChangeSet"
http://code.google.com/p/pharo/issues/detail?id=5349

The use of change sets has changed. They are just used transiently, we  
clear change set logs very frequently.

Therefore: searching in which change set the method used to be from  
originally makes no sense.
In addition, the code needed the machinery of revertible change sets, which  
we have removed nearly completely.

The attached code removes the menu item in the VersionBrowser and the  
implementation (which relied on low level access to the sources/changes  
file which is evil).

After filing this in, there is no users anymore of the pointer to the  
method in the MethodChangeRecord.
(that means: this can be simplified next).

cs attached

Attachments:
        CleanFindOriginalChangeSet.1.cs  2.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5349 in pharo: remove "findOriginalChangeSet"

pharo
Updates:
        Status: Integrated

Comment #1 on issue 5349 by [hidden email]:  
remove "findOriginalChangeSet"
http://code.google.com/p/pharo/issues/detail?id=5349

in 14348


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker