Issue 5350 in pharo: StartupLoader>>loadPreferences uses fileIn for non-fileIn format file

Status: New
Owner: ----

New issue 5350 by [hidden email]:  
StartupLoader>>loadPreferences uses fileIn for non-fileIn format file
http://code.google.com/p/pharo/issues/detail?id=5350

Pharo1.4a #14341 cogwin_r2522

When I use the following startup script...
StartupLoader default executeAtomicItems: {
     StartupAction name: 'Shared Package Cache' code: [ MCCacheRepository  
default directory setPathName: 'C:\Apps\Smalltalk\!Shared-Package-Cache'.].
}.

it fails with a syntax error due to...

     StartupLoader>>loadPreferences
         self retreiveFilesStream do: [:file | file fileIn ].

treating all single exclamation marks as defining the start of a chunk ...

     MultiByteFileStream(PositionableStream) >> fileInAnnouncing:
         "This is special for reading expressions from text that has been  
formatted with exclamation delimitors."
         ... [ | chunk | val := (self peekFor: $!) ...

and requiring real exclamation marks within the code to be doubled.

The exclaimation mark is a valid character for a folder name and should be  
allowed without having to escape it.  The startup scripts actually seem to  
not use the fileOut format.  At least the examples don't use exclamation  
marks at all. Folder !Shared-Package-Cache should be valid.

Perhaps StartupLoader>>loadPreferences can load the script into a string  
and execute it the same as would happen in a Transcript.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5350 by [hidden email]:  
StartupLoader>>loadPreferences uses fileIn for non-fileIn format file
http://code.google.com/p/pharo/issues/detail?id=5350

Just reviewing the issues I have logged, to add a bit of  
clarification/focus, the problem is the exclamation mark in  
foldername '!Share-package-Cache'.  I used the exclamation mark just so  
that this folder sorted to the top of my directory list.  I actually have  
since changed out the '!' for '#' - so I am not directly affected by this  
anymore.  However '!' I think this is still a valid low-priority issue  
since it might bite someone else, since '!' is a valid pathname character.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker