Issue 5356 in pharo: Make border of windows widther

Status: Accepted
Owner: marianopeck
CC: [hidden email],  [hidden email]
Labels: Type-Nautilus

New issue 5356 by marianopeck: Make border of windows widther
http://code.google.com/p/pharo/issues/detail?id=5356

When you are in a pane, say Class column, you press the right arow ->  and  
the focus goes to the next column, so if you do down arrow now you start to  
move between methods. However, when you move from column, the first row  
(protocols in this case) of the right column is not highlighted so you  
don't really know if you are there or not until you start to move (like  
arrow down).  So, I would autoselect/autohighlight first row of next column  
in that case.

Ben answered:


The selected list is surrounded by a light blue rectangle. I think the  
width of this border should be increase a bit, but it depends of the  
theme :)


So...not sure if this is Nautilus or Pharo itself, but I would really  
appreciate something widther and easier to see :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

It's a Pharo Theme issue. I will have a look to see if I can do something


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

in the method #newFocusIndicatorMorphFor:

the width is there.
Maybe we should make a setting for that ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #3 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

I added a slice in the inbox where I add a new setting to set the focus  
indicator width :)

Hope you will enjoy it


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

I think that building settings at this rhythm will not serve us in the  
future, because we will simply be flooded with them :).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

you may be right :)

I like to have a lot of settings, like that I can specify how I want my IDE  
to be. Then i use StartupScript to set up everything :)

Here I propose a slice, if the integrators decide not to integrate it, I  
will no be upset :)
(and I can also create a StartupScript to load my own theme or to override  
the method ;))

BTW I saw there is a lot of Theme Settings, and you have to set everything  
by hand if you want to specify it. Maybe a Theme Setting Browser could be  
done, just to specify those appearance settings.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

I would just set the border size to a confortable value.
I agree with Doru. Settings are easy to add but more difficult to remove.  
IMHO, we should remove a lot of settings and review the implementation of  
UITheme.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5356 by marianopeck: Make border of windows widther
http://code.google.com/p/pharo/issues/detail?id=5356

Hi guys. I agree with both: having lots of references is not good, but at  
the same time the border as it is right now is useless because I don't see  
it. The current value is 1. I think the value should be betwee 2 and 3. I  
really like the witdh 3, but I can also live with 2. I really think that  
the UI should be practilar, and having an easy way to spot where you ahve  
the focus is good.

So...what do you think?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.4

Comment #8 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #9 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.4

Comment #10 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

Do we need that for 1.4?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #11 on issue 5356 by marianopeck: Make border of windows widther
http://code.google.com/p/pharo/issues/detail?id=5356

so guys can I set the width 2 please?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

yes please



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

Just, please do not hardcode this setting, just leave it for the theme to  
set it up.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 5356 by marianopeck: Make border of windows widther
http://code.google.com/p/pharo/issues/detail?id=5356

Hi Tudor, can you be more clear? I don't understand. You said: "Just,  
please do not hardcode this setting, just leave it for the theme to set it  
up."

1) "do not hardcode". Few lines above you said NO to have a setting. So?
2) "just leave it for the theme". This mehtod #newFocusIndicatorMorphFor:  
is in the Theme class so I don't understand.

Thanks!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

I guess #newFocusIndicatorMorphFor: is the method to change. You can have a  
new method that return the desired border width and call it from  
#newFocusIndicatorMorphFor:.
However I've checked and it seems that it has no effect with the Pharo  
standard theme.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #16 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

Slice in the inbox
- Set the value at 2 (in PharoTheme)
- Categorize method from 'as yet unclassified' (the power of CMD+h,CMD+C)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Type-Nautilus Type-Bug Milestone-2.0

Comment #17 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #18 on issue 5356 by [hidden email]: Make border of windows  
widther
http://code.google.com/p/pharo/issues/detail?id=5356

in 2.0 209


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker