Status: Accepted
Owner:
[hidden email]
Labels: Type-Bug
New issue 5406 by
[hidden email]: SmalltalkEditor>>notify:at:in: and
SmalltalkEditor>>selectionForDoitAsStream not in sync
http://code.google.com/p/pharo/issues/detail?id=5406#selectionForDoitAsStream uses the old ReadStream on:from:to:
Such stream starts at position given by the second parameter (from:) minus
one.
This enables Compiler to mark token positions relative to the beginning of
Text, rather than relative to the beginning of selection being evaluated.
This old hack was used in Squeak.
SmalltalkEditor>>notify:at:in: on the other hand comes from Cuis and
expects an offset given from the beginning of sub-selection, thus syntax
errors are reported at wrong place when evaluating a sub-selection in a
Text.
When accepting a text with a sub-selection in the browser I can observe
that syntax errors are not reported at the right location due to
SmalltalkEditor>>notify:at:in:, so the error is not only when evaluating
sub-selection, I think this method is wrong.
I suggest reverting SmalltalkEditor>>notify:at:in: like I did in Squeak and
like Juan did in Cuis.
Then if we really want to get rid of of ReadStream on:from:to:, we should
then remove selectionForDoitAsStream and replace senders with
selectionAsStream.
One idea to have correct location of token would be to initialize
requestorOffset with requestor editor startIndex - 1
I think the other places in the Compiler interacting with the requestor
selectionInterval and token positions would work.
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Locked
