Issue 5456 in pharo: ClassBuilder depends on Text

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5456 in pharo: ClassBuilder depends on Text

pharo
Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.5

New issue 5456 by [hidden email]: ClassBuilder depends on Text
http://code.google.com/p/pharo/issues/detail?id=5456

 From The Mailing list:

ClassBuilder>>validateClassName: aString
     "Validate the new class name"
     | allowed |
     aString isSymbol
         ifFalse: [ ^ false ].
     allowed := ($0 to: $9), {$_}, ($A to: $Z), ($a to: $z).
     (aString detect: [:c | (allowed includes: c) not] ifNone: [ ])
         ifNotNil: [ :c | self error: 'Invalid character: ''', c  
printString, ''''.
             ^ false].
     aString first canBeGlobalVarInitial ifFalse:[
         self error: 'Class names must be capitalized'.
         ^false].
     environ at: aString ifPresent:[:old|
         (old isKindOf: Behavior) ifFalse:[
             self notify: aString asText allBold,
                         ' already exists!\Proceed will store over it.'  
withCRs]].
     ^ true


Is it right to do that asText allBold there? :S
Shouldn't an exception be raised instead?




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5456 in pharo: ClassBuilder depends on Text

pharo
Updates:
        Labels: Type-Cleanup

Comment #1 on issue 5456 by [hidden email]: ClassBuilder depends on  
Text
http://code.google.com/p/pharo/issues/detail?id=5456

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5456 in pharo: ClassBuilder depends on Text

pharo
Updates:
        Status: FixToInclude
        Labels: -Milestone-1.5 Milestone-1.4

Comment #2 on issue 5456 by [hidden email]: ClassBuilder depends on  
Text
http://code.google.com/p/pharo/issues/detail?id=5456

fix attached

Attachments:
        Fix.1.cs  774 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5456 in pharo: ClassBuilder depends on Text

pharo
Updates:
        Status: Integrated

Comment #3 on issue 5456 by [hidden email]: ClassBuilder depends on  
Text
http://code.google.com/p/pharo/issues/detail?id=5456

in 14390


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker