Issue 5461 in pharo: Test failing: MCFileInTest>>testStWriter

Status: FailingTest
Owner: [hidden email]
CC: [hidden email]
Labels: Type-Bug Milestone-1.4

New issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

MCFileInTest>>testStWriter is failing since 14387

maybe related to Issue 5441 ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

Not easy to fix...
Probably an effect of the timeStamp realignment.
Already spent one hour.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

Interesting note (need to try this again):

- deleted package monticellomocks
- ran all MC tests once.
- ran them again --> test does not fail anymore, but two other ones that  
are related to timestamp being empty.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #3 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

I will put the following in the postscript:

MCWorkingCopy registry
                removeKey: (MCPackage new name: 'Monticellomocks')
                ifAbsent:[].
PackageOrganizer default unregisterPackageNamed: 'Monticellomocks'.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #4 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

in 14398


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FailingTest

Comment #5 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

No, did not help.

The monticello tests are really not well done. Far to brittle, very complex.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

I will check because I want to understand what is the problem.
But it takes times. Probably something stupid.
I have also the impression that we lost time stamp I have to investigate.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

I don't think that it is directly related to the time stamp.

The test fails because there is a *monticellomocks extension. This was  
added because another test failed ages ago.

I think we should

  - remove that extension
  - remove that other test for now.

I will check... we need green tests else we will never ever be able to  
assess the if a VM build is ok.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

I located the point where it started to fail. It
was in update 14387, issue 5441
(http://code.google.com/p/pharo/issues/detail?id=5441) and in change
of method ClassDefinition >>
#printCategoryChunk:on:withStamp:priorMethod:.

In failure case there is a timestamp in form of String in the changeStamp.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

we may fix it with something like that but...

Attachments:
        ClassDescription-printCategoryChunkonwithStamppriorMethod.st  1.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

The problem is that some changes are not string and they do not understand  
size
so boum....

changeStamp size > 0

this part of the system is so old and brittle.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

We should revert  Issue 5441 and postpone any changes there to 1.5.... we  
need to focus else we will never release 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

Yes so may be we should open 1.5 because I introduce the changes because  
they broke something else.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

Issue 5532 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

Next Action: Code for undoing the changes needed.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

undo .cs attached

Attachments:
        Undo.1.cs  3.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #16 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #17 on issue 5461 by [hidden email]: Test failing:  
MCFileInTest>>testStWriter
http://code.google.com/p/pharo/issues/detail?id=5461

in 14410


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker