Issue 5462 in pharo: improve comment of join:

Status: Accepted
Owner: [hidden email]

New issue 5462 by [hidden email]: improve comment of join:
http://code.google.com/p/pharo/issues/detail?id=5462

If you fill an issue for the first time, please read "How to report bugs"
at http://www.pharo-project.org/community/issue-tracking

Pharo image: <core, dev or web>
Pharo core version: <copy from World/System/About>
Virtual machine used: <ex: pharo-vm-0.15.2f-linux>
Class browser used if applicable: <ex: O2PackageBrowserAdaptor. If you
don't
know, print "SystemBrowser default">

Steps to reproduce:
1.
2.
3.


Paste or attach stack trace if applicable (look at the file PharoDebug.log
located in the same directory as your image):



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Labels: Milestone-1.4

Comment #1 on issue 5462 by [hidden email]: improve comment of join:
http://code.google.com/p/pharo/issues/detail?id=5462

We are reallllllly bad. The comments suck a lot. No comment! :(

Here is a comment for String>>join:

String>>join: aCollection
        "'*' join: #('WWWWW' 'W  EW' 'zzzz')
                ->  'WWWWW*W  EW*zzzz' "
        ^ String
                streamContents: [:stream | aCollection
                                do: [:each | stream nextPutAll: each asString] "NB: coerce elements to  
Strings"
                                separatedBy: [stream nextPutAll: self]]

Attachments:
        String-join.st  434 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5462 by [hidden email]: improve comment of join:
http://code.google.com/p/pharo/issues/detail?id=5462

"Append the receiver in between elements of the arguments"


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5462 by [hidden email]: improve comment of join:
http://code.google.com/p/pharo/issues/detail?id=5462

"Return a new instance of the receiver by appending the receiver in between  
elements of the arguments."

"Return a String by appending the receiver in between elements of the  
arguments."

This is really hard...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded
        Labels: -Milestone-1.4

Comment #5 on issue 5462 by [hidden email]: improve comment of join:
http://code.google.com/p/pharo/issues/detail?id=5462

So what is the conclusion? I will add stef's and put this back to "work  
needed"


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker