Issue 5469 in pharo: Refactoring in DropList + Fix wrap

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-1.4

New issue 5469 by [hidden email]: Refactoring in DropList + Fix wrap
http://code.google.com/p/pharo/issues/detail?id=5469

All methods were uncategorized + the wrapping system was wrong since the  
model of the list is the drop list, not the drop list model.


Slice is incoming


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5469 by [hidden email]: Refactoring in DropList  
+ Fix wrap
http://code.google.com/p/pharo/issues/detail?id=5469

Slice is in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #2 on issue 5469 by [hidden email]: Refactoring in DropList  
+ Fix wrap
http://code.google.com/p/pharo/issues/detail?id=5469

After loading, all drop lists (e.g. in the browser) show the name 'like  
this' (with the quotes).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #3 on issue 5469 by [hidden email]: Refactoring in DropList  
+ Fix wrap
http://code.google.com/p/pharo/issues/detail?id=5469

Fixed, a stupid "printString" instead of "asString"


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 5469 by [hidden email]: Refactoring in DropList  
+ Fix wrap
http://code.google.com/p/pharo/issues/detail?id=5469

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 5469 by [hidden email]: Refactoring in DropList  
+ Fix wrap
http://code.google.com/p/pharo/issues/detail?id=5469

About the validated version, I pushed only the package "Polymorph-Widget"  
instead of the slice :s Sorry about that ...

A new version with
  - recategorization in EditableDropListMorph and SearchMorph
- UITheme editableDropListMargins fixed
- updateContents recategorized to allow subclasses to easily reuse it  
(introduce 2 hook points)

This time I push the  
slice "SLICE-Issue-5469-Refactoring-in-DropList--Fix-wrap-BenjaminVanRyseghem.2"


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5469 by [hidden email]: Refactoring in DropList  
+ Fix wrap
http://code.google.com/p/pharo/issues/detail?id=5469

So by the way, this slice includes the issue 5472


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5469 by [hidden email]: Refactoring in DropList  
+ Fix wrap
http://code.google.com/p/pharo/issues/detail?id=5469

New version

Fix the layout
Add ghostText on DropLIst
Add "escape close the list" this part will work with issue 5474 (but the  
code can be executed even without it)
Finish to categorize every methods of DropLis, EditableDropList, and  
SearchMorph.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #8 on issue 5469 by [hidden email]: Refactoring in DropList  
+ Fix wrap
http://code.google.com/p/pharo/issues/detail?id=5469

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #9 on issue 5469 by [hidden email]: Refactoring in DropList  
+ Fix wrap
http://code.google.com/p/pharo/issues/detail?id=5469

in 14393


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker