Issue 5476 in pharo: File Browser "Invalid utf8 input detected" when clicking on a binary file

Status: New
Owner: ----
Labels: Milestone-1.4 Type-Bug

New issue 5476 by [hidden email]: File Browser "Invalid utf8 input  
detected" when clicking on a binary file
http://code.google.com/p/pharo/issues/detail?id=5476

Clicking on a file in the File Browser immediately loads a preview of its  
contents. Works fine for text files, but when the file is binary  
(eg .image, .png) the above error is raised.

Naïve fix attached, wrapping calls to MultiByteFileStream>>contents and  
MultiByteFileStream>>next: in FileList>>readContentsBrief in an "on: Error  
do:" handler.

Attachments:
        FileList-readContentsBrief-onError.2.cs  1.4 KB

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5476 by [hidden email]: File Browser "Invalid  
utf8 input detected" when clicking on a binary file
http://code.google.com/p/pharo/issues/detail?id=5476

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #2 on issue 5476 by [hidden email]: File Browser "Invalid  
utf8 input detected" when clicking on a binary file
http://code.google.com/p/pharo/issues/detail?id=5476

ok, lets add that as a workaround for now.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #3 on issue 5476 by [hidden email]: File Browser "Invalid  
utf8 input detected" when clicking on a binary file
http://code.google.com/p/pharo/issues/detail?id=5476

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker