Issue 5478 in pharo: MultiCompositionScanner depending on Morphic stuff

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5478 in pharo: MultiCompositionScanner depending on Morphic stuff

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup

New issue 5478 by [hidden email]: MultiCompositionScanner depending  
on Morphic  stuff
http://code.google.com/p/pharo/issues/detail?id=5478

-  
MultiCompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide:

depends on TextLine which is packaged as Morphic-Text Support

- MultiCompositionScanner>>setFont

depends on TextComposer which is packaged as Morphic-Text Support also





_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5478 in pharo: MultiCompositionScanner depending on Morphic stuff

pharo

Comment #1 on issue 5478 by [hidden email]: MultiCompositionScanner  
depending on Morphic  stuff
http://code.google.com/p/pharo/issues/detail?id=5478

lots of classes are in wrong packages... e.g. Canvas is in Morphic.

We need to move things around and decpouple the canvas from morphic and  
text from morphic.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5478 in pharo: MultiCompositionScanner depending on Morphic stuff

pharo

Comment #2 on issue 5478 by [hidden email]: MultiCompositionScanner  
depending on Morphic  stuff
http://code.google.com/p/pharo/issues/detail?id=5478

     -  
MultiCompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide:

     depends on TextLine which is packaged as Morphic-Text Support


TextLine seems that can be safely moved along with MultiCompositionScanner.



     - MultiCompositionScanner>>setFont

     depends on TextComposer which is packaged as Morphic-Text Support also


This dependency is only for this method:

TextComposer class>>characterForColumnBreak

     ^Character value: 12

But if this method is so used by the scanner, then we can move it to the  
scanner and revert the dependency :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5478 in pharo: MultiCompositionScanner depending on Morphic stuff

pharo

Comment #3 on issue 5478 by [hidden email]: MultiCompositionScanner  
depending on Morphic  stuff
http://code.google.com/p/pharo/issues/detail?id=5478

 From the mailing list Igor said:

Hey, composition scanners and display scanners should not belong to Kernel.
they should be either in graphics package or in morphic itself.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5478 in pharo: MultiCompositionScanner depending on Morphic stuff

pharo
Updates:
        Status: Invalid

Comment #4 on issue 5478 by [hidden email]: MultiCompositionScanner  
depending on Morphic  stuff
http://code.google.com/p/pharo/issues/detail?id=5478

Ok, I was using an old image again... I'll update and remove all my old  
images.

In the latest image this is packaged better.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker