Issue 5487 in pharo: Deferring the calculation of the failure description string in TestCases

Status: New
Owner: ----
Labels: Milestone-1.4 Type-Feature

New issue 5487 by [hidden email]: Deferring the calculation of the  
failure description string in TestCases
http://code.google.com/p/pharo/issues/detail?id=5487

Calculating the failure description string for a failing assert is only  
necessary if the assert fails.


I deferred the calculation by giving it as a block, and evaluating the  
block only in the error case.
That might give some minor speedup for large test suites.

The patch is basically untested.
I use it to avoid all the calculations when debugging on the bytecode  
level, but in another image, and in a very restricted use case. So, use  
with caution.

Attachments:
        TestCase.2.cs  3.6 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5487 by [hidden email]: Deferring the  
calculation of the failure description string in TestCases
http://code.google.com/p/pharo/issues/detail?id=5487

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5487 by [hidden email]: Deferring the  
calculation of the failure description string in TestCases
http://code.google.com/p/pharo/issues/detail?id=5487

We should fix Issue 5147, too


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5487 by [hidden email]: Deferring the  
calculation of the failure description string in TestCases
http://code.google.com/p/pharo/issues/detail?id=5487

I do not really see the point to have a block for a description.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5487 by [hidden email]: Deferring the calculation of  
the failure description string in TestCases
http://code.google.com/p/pharo/issues/detail?id=5487

Do you see a point in doing needless computation?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.4 Milestone-1.5

Comment #5 on issue 5487 by [hidden email]: Deferring the  
calculation of the failure description string in TestCases
http://code.google.com/p/pharo/issues/detail?id=5487

Moved to 1.5


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5487 by [hidden email]: Deferring the  
calculation of the failure description string in TestCases
http://code.google.com/p/pharo/issues/detail?id=5487

in 12122


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #8 on issue 5487 by [hidden email]: Deferring the  
calculation of the failure description string in TestCases
http://code.google.com/p/pharo/issues/detail?id=5487

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker