Issue 5496 in pharo: UIManager>>grafPort should be made abstract

Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup

New issue 5496 by [hidden email]: UIManager>>grafPort should be made  
abstract
http://code.google.com/p/pharo/issues/detail?id=5496

grafPort
       
        ^ Display defaultBitBltClass current


should be

grafPort
        self subclassResponsibility


Since the upper behaviour is managed by the specific UIManager  
implementations


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5496 by [hidden email]: UIManager>>grafPort  
should be made abstract
http://code.google.com/p/pharo/issues/detail?id=5496

(No comment was entered for this change.)

Attachments:
        grafport.1.cs  216 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5496 by [hidden email]: UIManager>>grafPort  
should be made abstract
http://code.google.com/p/pharo/issues/detail?id=5496

does it avoid the introduction of the dependency?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5496 by [hidden email]: UIManager>>grafPort  
should be made abstract
http://code.google.com/p/pharo/issues/detail?id=5496

If fix the UIManager class...  Display should only be used on Graphic  
UIManagers.

Then there are other related things to fix, but step by step :P


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 5496 by [hidden email]: UIManager>>grafPort  
should be made abstract
http://code.google.com/p/pharo/issues/detail?id=5496

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 5496 by [hidden email]: UIManager>>grafPort  
should be made abstract
http://code.google.com/p/pharo/issues/detail?id=5496

in 14399


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #7 on issue 5496 by [hidden email]: UIManager>>grafPort should  
be made abstract
http://code.google.com/p/pharo/issues/detail?id=5496

The only sender of #grafPort is:

FormCanvas>>portClass
       
        "Return the class used as port"
        ^ UIManager default grafPort

and the only implementation is

defaultBitBltClass
        "Return the BitBlt version to use when I am active"
        ^BitBlt

IMO this is clearly overengineered.. and do we expect new kinds of graf  
ports appear on horizon?

i propose to just remove this . and replace
portClass
   ^ BitBlt asGrafPort

and remove it from UIManager as well as from Display #defaultBitBltClass
and all its senders..



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5496 by [hidden email]: UIManager>>grafPort  
should be made abstract
http://code.google.com/p/pharo/issues/detail?id=5496

definitely



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #9 on issue 5496 by [hidden email]: UIManager>>grafPort  
should be made abstract
http://code.google.com/p/pharo/issues/detail?id=5496

attached

Attachments:
        CleanGraphPort.1.cs  366 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 5496 by [hidden email]: UIManager>>grafPort  
should be made abstract
http://code.google.com/p/pharo/issues/detail?id=5496

in 14408


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker