Issue 5506 in pharo: author should be added to RGMethodDefinition and authors to RGClassDefinition

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Milestone-1.4

New issue 5506 by [hidden email]: author should be added to  
RGMethodDefinition and authors to RGClassDefinition
http://code.google.com/p/pharo/issues/detail?id=5506

to keep the interface in sync between CompiledMethod and RGMethodDefinition

should be something like

author
        "Answer the author of the current version of the receiver. retrieved from  
the sources or changes file. Answer the empty string if no time stamp is  
available."

        ^ self timeStamp
                ifNotEmpty: [:s | s subStrings first ]


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5506 by [hidden email]: author should be added to  
RGMethodDefinition and authors to RGClassDefinition
http://code.google.com/p/pharo/issues/detail?id=5506

RGMethodDefinition does not need that.. It already has #authorAlias.. the  
name can be renamed to #author, but I prefer #authorAlias as that is what  
in most cases is registered.

Do not change the implementation, the one proposed won't work (timestamp  
does not have the alias name).

The class has not #authors but that could be easily added





_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5506 by [hidden email]: author should be added  
to RGMethodDefinition and authors to RGClassDefinition
http://code.google.com/p/pharo/issues/detail?id=5506

authorAlias sucks!



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5506 by [hidden email]: author should be added  
to RGMethodDefinition and authors to RGClassDefinition
http://code.google.com/p/pharo/issues/detail?id=5506

The name :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5506 by [hidden email]: author should be added to  
RGMethodDefinition and authors to RGClassDefinition
http://code.google.com/p/pharo/issues/detail?id=5506

are you taking about the name? in that case rename it...

Be aware that stamp (the whole string) can be one of these:

<authorname><date><time>
<authorname><date>
<date><time>
<date><time><authorname>
<date><authorname>
<historical>

So taking only the first substring will only work for some cases.  I know,  
for most of them, but not for old methods.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5506 by [hidden email]: author should be added  
to RGMethodDefinition and authors to RGClassDefinition
http://code.google.com/p/pharo/issues/detail?id=5506

Thanks for the refresh.
We should really fix this one of these days.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.4

Comment #7 on issue 5506 by [hidden email]: author should be added  
to RGMethodDefinition and authors to RGClassDefinition
http://code.google.com/p/pharo/issues/detail?id=5506

So I guess this is not a show stopper for 1.4?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker