Issue 5512 in pharo: CommandLineUIManager and DummyUIManager depending on display

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Type-Cleanup

New issue 5512 by [hidden email]: CommandLineUIManager and  
DummyUIManager depending on display
http://code.google.com/p/pharo/issues/detail?id=5512

Those two UIManagers should not depend on graphic support.

        CommandLineUIManager>>displayProgress:from:to:during:
        CommandLineUIManager>>grafPort
        DummyUIManager>>displayProgress:from:to:during:
        DummyUIManager>>checkForNewDisplaySize
        DummyUIManager>>newDisplayDepthNoRestore:


Also, DummyUIManager accesses Sensor directly in #restoreDisplayAfter:

As I see,
- grafPort should not be there, or cancelled, or whatever
- displayProgress:from:to:during: use the center of the screen, but If we  
have no screen, maybe we should get that value from other place, or  
hardcode a default (0@0 ?) letting users choose to use  
#displayProgress:at:from:to:during: if they want to specify


Something I don't get:  Is DummyUIManager supposed to behave like Morphic  
UIManager if there is a Display and as CommandLineUIManager if not?  Why  
not just use delegation to do that instead of copying the whole methods and  
testing the display with ifs?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5512 by [hidden email]: CommandLineUIManager and  
DummyUIManager depending on display
http://code.google.com/p/pharo/issues/detail?id=5512

sooner or later I will implement a progress bar for the command-line,  
though not a morphic one ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5512 by [hidden email]: CommandLineUIManager and  
DummyUIManager depending on display
http://code.google.com/p/pharo/issues/detail?id=5512

ok, so making methods do nothing with a nice comment meanwhile is ok :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5512 by [hidden email]: CommandLineUIManager and  
DummyUIManager depending on display
http://code.google.com/p/pharo/issues/detail?id=5512

yes. this stuff is too low level for users of UI manager.
to my perspective, UI manager is something higher than stuff like display  
depth..or grafport


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker