Issue 5521 in pharo: Object>>deprecated:on:in: doesn't respect Deprecation class>showWarning setting

Status: New
Owner: ----
Labels: Milestone-1.4 Type-Bug

New issue 5521 by [hidden email]: Object>>deprecated:on:in: doesn't  
respect Deprecation class>showWarning setting
http://code.google.com/p/pharo/issues/detail?id=5521

If you fill an issue for the first time, please read "How to report bugs"
at http://www.pharo-project.org/community/issue-tracking

Pharo image: <core, dev or web>
Pharo core version: 14399
Virtual machine used: Cog VM 4.0.0 (release)
Class browser used if applicable: N/A

Steps to reproduce:
1. Disable deprecation warnings with "Deprecation showWarning: false"
2. Execute a deprecated message that sends deprecated:on:in:, eg "true and:  
[ true ] and: [ true ]"
3. Observe warning dialog.  IMO a dialog should not be displayed in this  
circumstance.

Fix is to wrap contents of Object>>deprecated:on:in: in a Deprecation  
showWarning ifTrue: [...] conditional per attached.

Attachment also corrects a string typo in Object>>deprecated:

Attachments:
        DeprecationFixes.1.cs  692 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5521 by [hidden email]:  
Object>>deprecated:on:in: doesn't respect Deprecation class>showWarning  
setting
http://code.google.com/p/pharo/issues/detail?id=5521

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5521 by [hidden email]: Object>>deprecated:on:in:  
doesn't respect Deprecation class>showWarning setting
http://code.google.com/p/pharo/issues/detail?id=5521

OK, my bad.  Misunderstood difference between showWarning and raiseWarning  
(Transcript output versus dialog window).  raiseWarning is what I wanted  
and works as expected.  Apologies for any wasted effort here.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Invalid

Comment #3 on issue 5521 by [hidden email]:  
Object>>deprecated:on:in: doesn't respect Deprecation class>showWarning  
setting
http://code.google.com/p/pharo/issues/detail?id=5521

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker