Issue 5523 in pharo: Collection union: and intersection: should use species

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5523 in pharo: Collection union: and intersection: should use species

pharo
Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4 Type-Bug Difficulty-Easy

New issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

The new implementation of union: and intersection: refer directly to the  
class of the current collection. Instead, they should use species.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5523 in pharo: Collection union: and intersection: should use species

pharo
Updates:
        Status: FixToInclude

Comment #1 on issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

Slice created in the inbox.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5523 in pharo: Collection union: and intersection: should use species

pharo

Comment #2 on issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

Name:  
SLICE-Issue-5523-Collection-union-and-intersection-should-use-species-TudorGirba.1
Author: TudorGirba
Time: 20 March 2012, 7:25:55 am
UUID: b3944736-b2d8-4c30-ad24-3c39c2a18cf9
Ancestors:
Dependencies: Collections-Abstract-TudorGirba.158

use species instead of class for Collection>>union: and intersection:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5523 in pharo: Collection union: and intersection: should use species

pharo
Updates:
        Status: Integrated

Comment #3 on issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

in 14404


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5523 in pharo: Collection union: and intersection: should use species

pharo
Updates:
        Status: Workneeded

Comment #4 on issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

Nope, not integrated.

The attached Slice removes groupedBy: and #includesAll: and sum: from  
Collection.
Was that intended?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5523 in pharo: Collection union: and intersection: should use species

pharo

Comment #5 on issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

Oops, too rushed. My bad. I will create another one.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5523 in pharo: Collection union: and intersection: should use species

pharo

Comment #6 on issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

Actually, the issue raised from Moose having these as extensions because  
they were missing before. The problem is that I cannot quite see these  
overrides.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5523 in pharo: Collection union: and intersection: should use species

pharo

Comment #7 on issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

The rule is: never do a Slice from an image that is not the 1.4 image...  
any loaded package (any) will just end up making trouble.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5523 in pharo: Collection union: and intersection: should use species

pharo

Comment #8 on issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

Got it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5523 in pharo: Collection union: and intersection: should use species

pharo

Comment #9 on issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

I created another slice. This time, it also fixes difference:

Name:  
SLICE-Issue-5523--Collection-union-and-intersection-should-use-species-TudorGirba.2
Author: TudorGirba
Time: 20 March 2012, 9:10:04 am
UUID: 1a348d52-f9bc-784f-a95f-c51baae1a94b
Ancestors:
Dependencies: Collections-Abstract-TudorGirba.159

only publish class->species change to:
- union:
- intersection:
- difference:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5523 in pharo: Collection union: and intersection: should use species

pharo
Updates:
        Status: FixToInclude

Comment #10 on issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5523 in pharo: Collection union: and intersection: should use species

pharo
Updates:
        Status: Integrated

Comment #11 on issue 5523 by [hidden email]: Collection union: and  
intersection: should use species
http://code.google.com/p/pharo/issues/detail?id=5523

in 14405


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker