Issue 5525 in pharo: Get rid of string comparison in MessageListBrowser and FlatMessageListBrowser

Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup Milestone-1.4

New issue 5525 by [hidden email]: Get rid of string comparison in  
MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

By introducing a DropListItem class.

It takes a label (use for list rendering) and a block.
When the item is selected, the block is performed


Slice is incoming


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5525 by [hidden email]: Get rid of string  
comparison in MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

Slice is in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #2 on issue 5525 by [hidden email]: Get rid of string  
comparison in MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

can not merge. Depends on package MethodConverters?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5525 by [hidden email]: Get rid of string  
comparison in MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

MethodConverters is in the Pharo 14405 (introduced in the last  
RecentMessageList fix)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #4 on issue 5525 by [hidden email]: Get rid of string  
comparison in MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5525 by [hidden email]: Get rid of string  
comparison in MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

When adding packages you need to tell... it needs manual fiddling (e.g.  
this package now has no repository attached and all changes are lost when  
integrating).

Is that really a stand alone package? 5 classes? Why not put it close to  
where the users are?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5525 by [hidden email]: Get rid of string  
comparison in MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

We can put them into RecentSubmissions.

But maybe Tool is a better place since they can/should be used as often as  
posible (I use them in spec by example)


Sorry for the mess


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Blockedon: 5527

Comment #7 on issue 5525 by [hidden email]: Get rid of string  
comparison in MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

Blocked


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #8 on issue 5525 by [hidden email]: Get rid of string  
comparison in MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

When I merge this, "implementors of" leads to a DNU


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5525 by [hidden email]: Get rid of string  
comparison in MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

I will have a look this afternoon :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #10 on issue 5525 by [hidden email]: Get rid of string  
comparison in MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

DNU fixed


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #11 on issue 5525 by [hidden email]: Get rid of string  
comparison in MessageListBrowser and FlatMessageListBrowser
http://code.google.com/p/pharo/issues/detail?id=5525

in 14408


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker