Issue 5531 in pharo: undo not wokring

Status: Accepted
Owner: ----
Labels: Milestone-1.4 Type-Bug

New issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

1. type a text
2. select the text
3. add double quotes around the text with the completion thingy
4. undo
5. => instead of having an empty line there is the last character of the  
text and the double quote

=> the same happes for all the other balanced characters introduced: '"[{(

plus from time to time there is more broken stuff than just the left-over  
characters, but I havent figured out a reproducible pattern yet


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Owner: [hidden email]

Comment #1 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

it seems to be related to OCompletion. As Ben confirmed it works in a fresh  
image.

'Gofer new
     squeaksource: 'MetacelloRepository';
     package: 'ConfigurationOfOCompletion';
     load.

(Smalltalk at: #ConfigurationOfOCompletion) perform: #loadStable.


makes this bug appear again :/.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

found:
EC uses zapSelectionWith: instead of replaceSelectionWith:.
undo actions are stored by replaceSelectionWith.

zapSelectionWith: should be renamed privateZapSelectionWith:, it would make  
clear it can be sent only by the textEditor.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #4 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

could you make a try with the attached cs


Attachments:
        encloseWithEC.1.cs  2.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

Ok I will check that.
Please not that I clean Ecompletion and produced a new package named  
NewECompletion.
The future work is to make sure that the new version of OCompletion  
(currently not working) will work in presence of ECompletion). The new  
OCompletion does not duplicate completely ECompletion. In the same vein  
NewECompletion has been cleaned (more or less the preferences are still  
managed in an external class and I do not get why).



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

Tested, it works.
Should't we then prepare a ConfigurationOfOCompletion using NewECompletion?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

Yes it would be good. Then the next step is to mkae OCompletion working  
with eCompletion.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

esteban if you look on ss30, you will see in the NEC project that there is  
a NewOCompletion = NOCompletion and this is the one that we should adapt to  
work with NECCompletion.


Gofer new
     repository: 'http://ss3.gemstone.com/ss/NEC';
     package: 'ConfigurationOfNewECompletion';
     package: 'NECompletion';
     package: 'NOCompletion';
     load




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

I integrated the changeset to latest Ocompletion configuration (1.4.1),  
please test.

btw, using new ecompletion should be ready for 1.4, or we move the  
integration to next version?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

What do you mean that latest OCompletion.
The old Ocompletion break ECompletion (because it copies everything and I  
clean the code) so please do not fix the old Ocompletion0.
The latest OCompletion is in NOCompletion on the previous project.
The new version is cleaned (no copy of ECompletion) moved method extension  
to the core
but it does not work. So we should use the new ECompletion in 1.4 (else I  
do not see why I spent my time on it) and we should fix the new OCompletion.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

is done, but now we need an "integration path"... or just include them into  
pharo?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

How do u feel it?
Marcus would say not used so no :) but we see fast it is breaks and this is  
so useful.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

No problem to just load it...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #14 on issue 5531 by [hidden email]: undo not wokring
http://code.google.com/p/pharo/issues/detail?id=5531

in 14427


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker