Issue 5534 in pharo: Do we rename/sync FS for 1.4?

Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup Milestone-1.4

New issue 5534 by [hidden email]: Do we rename/sync FS for 1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

Do we rename/sync FS for 1.4?

package FS is different to the official one, making it hard for people to  
load that.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

so what do we do?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

rename it I guess... avoiding all compatibility issues since we cannot have  
two versions of a same class yet in the image :)

names?
I am lazy => Just use a single Letter F prefix :) or none since it's going  
into to core...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

No prefix, I would say.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

renaming proposal:

- Packages: FS-Core => FileSystem-Core
- Classes:
     FSAbsolutePath => AbsolutePath
     FSVisitor => FileSystemVisitor | FileVisitor (for collisions or  
confusing names)

might have to be done in two steps to avoid collision with existing File  
implementation


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

And how difficult is to sync both implementations?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

no idea
For synching both parties should want and nobody asked colin.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

I like your renaming. :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #8 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

On SLICE-Issue-5534-Do-we-renamesync-FS-for-14-EstebanLorenzano.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

It seems

FileSystemReadStream
and
FileSystemWriteStream

is missing..

instead of doing the whole slice again, can you commit the package  
(FileSystem-AnsiStreams, I guess)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #10 on issue 5534 by [hidden email]: Do we rename/sync FS  
for 1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

-> some extensions are not yet moved
-> empty FS Packages need to be deleted


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #11 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

new version commited.
FS-* package removal needs to be done by hand


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #12 on issue 5534 by [hidden email]: Do we rename/sync FS  
for 1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

looks good


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #13 on issue 5534 by [hidden email]: Do we rename/sync FS  
for 1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

in 14421


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

I want to reopen this a bit... I noticed that there are some names that  
need rethinking. For instance "Reference"... is not a reference, is a file  
reference... so, Reference is too generic (also #asReference method is too  
generic also). If this is going to be core, we need more concrete names, I  
think.
I don't know if there are also more names too generic, but I would like to  
review it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

++1
it should be more specific, like FSReference, and corresponding conversion  
method should be #asFSReference

... a stupid google tries to teach me about good tone:
<This looks like a "+1" comment.
Please use the star icon instead.
Stars show your interest without annoying other users.>



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 5534 by [hidden email]: Do we rename/sync FS  
for 1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

Please review the names this is really important to get them right.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #17 on issue 5534 by [hidden email]: Do we rename/sync FS  
for 1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

asFileReference could be good.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #18 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

asFileReference reads well to me, assuming that Reference is renamed to  
FileReference.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #19 on issue 5534 by [hidden email]: Do we rename/sync FS for  
1.4?
http://code.google.com/p/pharo/issues/detail?id=5534

On second thoughts, since Reference can refer to either files or  
directories, the longer asFileSystemReference, and FileSystemReference  
might be better, and this fits better with the FileSystem and  
FileSystemDirectoryEntry.

Should we also be thinking about renaming Locator?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker