Issue 5561 in pharo: SourcedMethodReference>>printOn: is misleading

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5561 in pharo: SourcedMethodReference>>printOn: is misleading

pharo
Status: New
Owner: ----
Labels: Milestone-1.3 Type-Bug

New issue 5561 by [hidden email]: SourcedMethodReference>>printOn:  
is misleading
http://code.google.com/p/pharo/issues/detail?id=5561

SourcedMethodReference>>printOn: is misleading.  When one looks at a method  
reference in the debugger, it is not clear if it refers to a class to a  
metaClass; they print the same.

Fix:

printOn: aStream
        aStream
                nextPutAll: classSymbol;
                nextPutAll: (classIsMeta
                                                ifTrue: [ ' class' ]
                                                ifFalse: [ '' ] );
                nextPutAll: ' >> #';
                nextPutAll: self methodSymbol asString

Actually, it's not clear to me why this method is overridden, and not just  
inherited from MethodReference, which gets the printing right.  The  
difference is that the code in SourceMethodReference omits the name of the  
class (that is, there is no  "a SourcedMethodReference" prefix on every  
printout).  But if this is a good idea, it should be adopted in  
MethodReference too.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5561 in pharo: SourcedMethodReference>>printOn: is misleading

Stéphane Ducasse
Hi andrew

do not work on 1.3 to propose fixes. 1.3 is one year old and we are about to release 1.4.
So lot of the points you may raise may be already obsolete.

Stef

On Mar 26, 2012, at 11:56 PM, [hidden email] wrote:

> Status: New
> Owner: ----
> Labels: Milestone-1.3 Type-Bug
>
> New issue 5561 by [hidden email]: SourcedMethodReference>>printOn: is misleading
> http://code.google.com/p/pharo/issues/detail?id=5561
>
> SourcedMethodReference>>printOn: is misleading.  When one looks at a method reference in the debugger, it is not clear if it refers to a class to a metaClass; they print the same.
>
> Fix:
>
> printOn: aStream
> aStream
> nextPutAll: classSymbol;
> nextPutAll: (classIsMeta
> ifTrue: [ ' class' ]
> ifFalse: [ '' ] );
> nextPutAll: ' >> #';
> nextPutAll: self methodSymbol asString
>
> Actually, it's not clear to me why this method is overridden, and not just inherited from MethodReference, which gets the printing right.  The difference is that the code in SourceMethodReference omits the name of the class (that is, there is no  "a SourcedMethodReference" prefix on every printout).  But if this is a good idea, it should be adopted in MethodReference too.
>
>
> _______________________________________________
> Pharo-bugtracker mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5561 in pharo: SourcedMethodReference>>printOn: is misleading

pharo
In reply to this post by pharo
Updates:
        Status: Wonfix

Comment #1 on issue 5561 by [hidden email]:  
SourcedMethodReference>>printOn: is misleading
http://code.google.com/p/pharo/issues/detail?id=5561

All this package is deprecated in 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5561 in pharo: SourcedMethodReference>>printOn: is misleading

pharo
Updates:
        Status: Invalid

Comment #2 on issue 5561 by [hidden email]:  
SourcedMethodReference>>printOn: is misleading
http://code.google.com/p/pharo/issues/detail?id=5561

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker