Issue 5593 in pharo: New ClassOrganizer

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5593 in pharo: New ClassOrganizer

pharo
Status: FixReviewNeeded
Owner: [hidden email]
CC: [hidden email],  [hidden email]
Labels: Milestone-1.5 Type-Cleanup Importance-High

New issue 5593 by [hidden email]: New ClassOrganizer
http://code.google.com/p/pharo/issues/detail?id=5593

We rewrote a new implementation of ClassOrganizer because the current one  
is too crappy


It's backward compatible, and seems to work (tested with the latest  
Nautilus)

Slice is incoming


script to migrate:

Smalltalk allClassesDo: [:c || org proOrg |
        org := c organization.
        proOrg := ClassOrganization importFrom: org.
        c organization: proOrg ].


Ben & Guillermo


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5593 in pharo: New ClassOrganizer

pharo

Comment #1 on issue 5593 by [hidden email]: New ClassOrganizer
http://code.google.com/p/pharo/issues/detail?id=5593

cool :)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5593 in pharo: New ClassOrganizer

pharo
Updates:
        Blockedon: 5594

Comment #2 on issue 5593 by [hidden email]: New ClassOrganizer
http://code.google.com/p/pharo/issues/detail?id=5593

We need to fix the file in first :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5593 in pharo: New ClassOrganizer

pharo

Comment #3 on issue 5593 by [hidden email]: New ClassOrganizer
http://code.google.com/p/pharo/issues/detail?id=5593

Slice in the inbox ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5593 in pharo: New ClassOrganizer

pharo

Comment #4 on issue 5593 by [hidden email]: New ClassOrganizer
http://code.google.com/p/pharo/issues/detail?id=5593

Smalltalk allClassesDo: [:c || org proOrg |
        org := c organization.
        proOrg := ClassOrganization importFrom: org.
        c organization: proOrg

        org := c class organization.
        proOrg := ClassOrganization importFrom: org.
        c class organization: proOrg
  ].



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5593 in pharo: New ClassOrganizer

pharo
In reply to this post by pharo
Updates:
        Status: FixToInclude

Comment #6 on issue 5593 by [hidden email]: New ClassOrganizer
http://code.google.com/p/pharo/issues/detail?id=5593

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5593 in pharo: New ClassOrganizer

pharo
Updates:
        Status: Workneeded
        Blockedon: -pharo:5594 pharo:5594

Comment #7 on issue 5593 by [hidden email]: New ClassOrganizer
http://code.google.com/p/pharo/issues/detail?id=5593

Do we want to add this now or do we wait until more tests are green?
(Changing everything at the same time and not finishing is problematic...)

What it needs:
    - the code is in its own package. But it should be close to Class
    - There are *a lot* of references to the old ClassOrganizer. Is it save  
to use both in parallel?




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5593 in pharo: New ClassOrganizer

pharo
In reply to this post by pharo

Comment #9 on issue 5593 by [hidden email]: New ClassOrganizer
http://code.google.com/p/pharo/issues/detail?id=5593

Ok, I put it in image, but I didn't run the migration, as you asked


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5593 in pharo: New ClassOrganizer

pharo

Comment #10 on issue 5593 by [hidden email]: New ClassOrganizer
http://code.google.com/p/pharo/issues/detail?id=5593

changed all references from ClassOrganizer to ClassOrganization and family .


Smalltalk allClassesAndTraitsDo: [:c || org proOrg |
        org := c theNonMetaClass organization.
        proOrg := ClassOrganization importFrom: org.
        c theNonMetaClass organization: proOrg.

        org := c theMetaClass organization.
        proOrg := ClassOrganization importFrom: org.
        c theMetaClass organization: proOrg
  ].


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5593 in pharo: New ClassOrganizer

pharo
Updates:
        Status: Integrated

Comment #11 on issue 5593 by [hidden email]: New ClassOrganizer
http://code.google.com/p/pharo/issues/detail?id=5593

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker