Issue 5595 in pharo: EllipseMorph>>cornerStyle: is missing statement terminator

Status: New
Owner: ----

New issue 5595 by [hidden email]: EllipseMorph>>cornerStyle: is missing  
statement terminator
http://code.google.com/p/pharo/issues/detail?id=5595

If you fill an issue for the first time, please read "How to report bugs"
at http://www.pharo-project.org/community/issue-tracking

Pharo image: 1.4a
Pharo core version: 14426
Virtual machine used: 6.0-pre (21.0)
Class browser used if applicable: Browser

EllipseMorph>>cornerStyle: is missing a '.' on the second line of it's  
implementation.  It should be:

EllipseMorph>>cornerStyle: aSymbol
        "Set the receiver's corner style.  But, in this case, do *not*"
        (extension isNil or: [self cornerStyle == aSymbol]) ifTrue: [^self].
        extension cornerStyle: nil. "<--- this '.' is missing"
        self changed

Found while cleaning up after cleanUpForProduction (unimplemented  
message "self").


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5595 by [hidden email]: EllipseMorph>>cornerStyle:  
is missing statement terminator
http://code.google.com/p/pharo/issues/detail?id=5595

Also PolygonMorph>>cornerStyle: looks like a copy/paste and has the same  
issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Labels: Type-Bug Milestone-1.4

Comment #2 on issue 5595 by [hidden email]:  
EllipseMorph>>cornerStyle: is missing statement terminator
http://code.google.com/p/pharo/issues/detail?id=5595

fix attached

Attachments:
        Fix.1.cs  655 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5595 by [hidden email]:  
EllipseMorph>>cornerStyle: is missing statement terminator
http://code.google.com/p/pharo/issues/detail?id=5595

Thanks.
Did you sign the license agreement


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5595 by [hidden email]: EllipseMorph>>cornerStyle:  
is missing statement terminator
http://code.google.com/p/pharo/issues/detail?id=5595

I'll post you a form, but I'm not sure that it's really needed here.  I'm  
not sure there is a bug that could take less pixels to fix :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5595 by [hidden email]:  
EllipseMorph>>cornerStyle: is missing statement terminator
http://code.google.com/p/pharo/issues/detail?id=5595

This is important for us because we can say to our employers that the  
community is growing (which is the case but they like data set).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.4 Milestone-1.5

Comment #6 on issue 5595 by [hidden email]:  
EllipseMorph>>cornerStyle: is missing statement terminator
http://code.google.com/p/pharo/issues/detail?id=5595

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.5 Milestone-1.4

Comment #7 on issue 5595 by [hidden email]:  
EllipseMorph>>cornerStyle: is missing statement terminator
http://code.google.com/p/pharo/issues/detail?id=5595

This is just a dot and *It* typed it myself.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #8 on issue 5595 by [hidden email]:  
EllipseMorph>>cornerStyle: is missing statement terminator
http://code.google.com/p/pharo/issues/detail?id=5595

in 14428


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker