Issue 5596 in pharo: DosFileDirectory>>preferencesRootPath broken

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4 Type-Bug Importance-High

New issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

At start up DosFileDirectory>>preferencesRootPath
broke with a Windows VM.

Tested with 1.3 one click VM and COG Windows WM found in Pharo web site.

Is it a problem from the VMs or the image? I don't know.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

It is related to http://code.google.com/p/pharo/issues/detail?id=5255

We need to add in DosFileDirectory>>preferencesRootPath:

osMajorVer = $4 ifTrue: [ "I don't know"].


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

Give the full code if you want to get a chance that it is integrated


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

I would like but I don't know what mean osMajorVer=$4 and what should be  
the rootPath with this OS version under Windows.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

This is a fix, but a Windows specialist should review it.

Attachments:
        DosFileDirectory class-preferencesRootPath.st  1.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

There is no such method in the 1.3 image.

"XP SP3"
Smalltalk os osVersion first. $5

Attachments:
        PharoScreenshot.1.png  171 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

As labelled, it is a Pharo 1.4 issue.
Tested with the VM found in the one-click 1.3 package


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

A better fix.

Attachments:
        DosFileDirectory class-preferencesRootPath.st  1.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

The last update of that code was by me.  It was hard finding the right info  
so I only did enough to get it working for the later Windows versions.  
I've now hunted down better info which I have appended to original issue  
5255 linked above.

Actually, it was not just the lack of version number.  It should have  
dropped through to the fallback case.  I've fixed that also.

Attachments:
        DosFileDirectory class-preferencesRootPath.st  1.8 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #9 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

1) patch does not works in localized versions of windows (I tested in a xp  
in spanish :P)
2) also... if directory does not exists it answer root, "\"... is that  
right?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

another thing: an unique config for All Users? is not too much? shouldn't  
be user based?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

Windows at least has an API especially for resolving this irresponsive of  
which version you're on...

If you drop Win98 support (which I think is already the case) the functions  
are: (for Vista onwards)
http://msdn.microsoft.com/en-us/library/windows/desktop/dd378457(v=vs.85).aspx

and back to Win2K:
http://msdn.microsoft.com/en-us/library/windows/desktop/bb762181(v=vs.85).aspx

Parts of it used to be accessible through the SecurityPlugin (though, with  
encoding bugs, f.ex. Janko had trouble with user name Mivsek, see issue  
3721 ), though it only remains in 1.4 as primUntrustedUserDirectory, and is  
broken on at least Cocoa VM's afaict.

Might be useful to abstract just the "known folders" functionality of  
SecurityPlugin into a correctly written, standalone plugin?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

The other way to go would be to be able to read an environment variable.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #14 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

ok, necessary actions taken:
1) in  
SLICE-Issue-5596-DosFileDirectorypreferencesRootPath-broken-EstebanLorenzano.1,  
I disabled preferences lookup. Now startup.st is taken just if present on  
image directory.
2) as real problem is that preference lookup in windows is broken and need  
to be revisited, I created a new issue for next milestone. See  
http://code.google.com/p/pharo/issues/detail?id=5618


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #15 on issue 5596 by [hidden email]:  
DosFileDirectory>>preferencesRootPath broken
http://code.google.com/p/pharo/issues/detail?id=5596

in 14432


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker