Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

pharo
Status: Accepted
Owner: ----
Labels: Milestone-1.4 Type-Bug

New issue 5605 by [hidden email]:  
DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click
http://code.google.com/p/pharo/issues/detail?id=5605

self assert: ('2002-05-16T17:20' asDateAndTime printString =  
('2002-05-16T17:20:00+{1}:{2}' format: {localOffsetHours.  
localOffsetMinutes})).

'2002-05-16T17:20' asDateAndTime printString is equals  
to '2002-05-16T17:20:00-03:00'
and
('2002-05-16T17:20:00+{1}:{2}' format: {localOffsetHours.  
localOffsetMinutes}) is equals to '2002-05-16T17:20:00+-3:00'
so the plus sign in the middle and a missed zero are the differences.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

pharo
Issue 5605: DateAndTimeTest>>testPrintStringNoOffset fails on  
pharo-one-click
http://code.google.com/p/pharo/issues/detail?id=5605

This issue is now blocking issue 5597.
See http://code.google.com/p/pharo/issues/detail?id=5597

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

pharo
In reply to this post by pharo
Updates:
        Labels: -Milestone-1.4 Milestone-2.0

Comment #2 on issue 5605 by [hidden email]:  
DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click
http://code.google.com/p/pharo/issues/detail?id=5605

Not relevant for 1.4 (is a failing test, not a failing functionality),  
moved to next version


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

pharo

Comment #3 on issue 5605 by [hidden email]:  
DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click
http://code.google.com/p/pharo/issues/detail?id=5605

Not relevant for 1.4 (is a failing test, not a failing functionality),  
moved to next version


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

pharo
In reply to this post by pharo
Updates:
        Status: FixReviewNeeded

Comment #5 on issue 5605 by [hidden email]:  
DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click
http://code.google.com/p/pharo/issues/detail?id=5605

Name:  
SLICE-Issue-5605-DateAndTimeTesttestPrintStringNoOffset-fails-on-pharo-one-click-GuillermoPolito.1
Author: GuillermoPolito
Time: 27 April 2012, 10:43:42.524 am
UUID: 0836d76d-c698-40ef-97cf-c1fa79c8385d
Ancestors:
Dependencies: KernelTests-GuillermoPolito.394

fixed test for negative timezones


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

pharo
Updates:
        Status: FixToInclude

Comment #6 on issue 5605 by [hidden email]:  
DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click
http://code.google.com/p/pharo/issues/detail?id=5605

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

pharo
Updates:
        Labels: -Milestone-2.0

Comment #7 on issue 5605 by [hidden email]:  
DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click
http://code.google.com/p/pharo/issues/detail?id=5605

in 2.0 025

TODO: 1.4 (just take the test from 2.0)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

pharo
Updates:
        Status: FailingTest
        Labels: Milestone-2.0

Comment #8 on issue 5605 by [hidden email]:  
DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click
http://code.google.com/p/pharo/issues/detail?id=5605

It is still failing on the build server in 2.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

pharo
Updates:
        Cc: [hidden email]

Comment #9 on issue 5605 by [hidden email]:  
DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click
http://code.google.com/p/pharo/issues/detail?id=5605

The test is failing on the build server, can you check it is green in your  
image?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

pharo
Updates:
        Status: FixToInclude

Comment #10 on issue 5605 by [hidden email]:  
DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click
http://code.google.com/p/pharo/issues/detail?id=5605

Oups, sorry.  I tested it in with negative offsets but not with positive  
ones again :/.
Hmm, it should be better to have two tests, one for each kind of offset  
maybe.

Fix in cs, just adds the + if the offset is positive :)

Attachments:
        printStringOffsetTest.1.cs  846 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5605 in pharo: DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click

pharo
Updates:
        Status: Integrated

Comment #11 on issue 5605 by [hidden email]:  
DateAndTimeTest>>testPrintStringNoOffset fails on pharo-one-click
http://code.google.com/p/pharo/issues/detail?id=5605

in 2.0 030


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker